From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D040FC4167B for ; Tue, 31 Oct 2023 07:54:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343815AbjJaHyX (ORCPT ); Tue, 31 Oct 2023 03:54:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343788AbjJaHyS (ORCPT ); Tue, 31 Oct 2023 03:54:18 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EE75DB; Tue, 31 Oct 2023 00:54:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1698738852; x=1730274852; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xN51CM09J6iiCjc32Yasf35DOisKTuCsqH+zHVd4erY=; b=itWmYCJqL6XK9sYKI91eNpc+noUPSZXNeg9TQEjA0Fu9aTkkbSyNZFfD incvx1PfruafMou1rPz1UCFPbdZVloBHPxOFc8Ek1NvT/lwj/daUhGB7c qwV6W0Jpcv9YXgyAr2kSSpXx2qEFprrsZOen8hOJUmq64vYDtFXwxOV0y rz4ckLGQ2l4boUnbE9YZjoSF5Ubz/nNaJX99ZwBuaXDsfviO1Dy3MceHt TPrI7BrBk3ciZ+H5DJMJod5b8zYy6xP/QKpQevHM9MJTBuLZ1B/o2tvxG F+ITnbOMJIU5WWYYq1CR6FRXc5/UtME17GRklippAqhM8WVxsjyrHqwJg A==; X-CSE-ConnectionGUID: LPH+QcWOTpS555ipnBfRWA== X-CSE-MsgGUID: 0Qv2u934SCCmsMjxrHIzVg== X-ThreatScanner-Verdict: Negative X-IronPort-AV: E=Sophos;i="6.03,265,1694761200"; d="asc'?scan'208";a="178052118" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 Oct 2023 00:54:11 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 31 Oct 2023 00:53:17 -0700 Received: from wendy (10.10.85.11) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 31 Oct 2023 00:53:15 -0700 Date: Tue, 31 Oct 2023 07:52:50 +0000 From: Conor Dooley To: Charlie Jenkins CC: "Wang, Xiao W" , "paul.walmsley@sifive.com" , "palmer@dabbelt.com" , "aou@eecs.berkeley.edu" , "ardb@kernel.org" , "anup@brainfault.org" , "Li, Haicheng" , "ajones@ventanamicro.com" , "Liu, Yujie" , "linux-riscv@lists.infradead.org" , "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 2/2] riscv: Optimize bitops with Zbb extension Message-ID: <20231031-triage-glacial-d70f5951627e@wendy> References: <20231030063904.2116277-1-xiao.w.wang@intel.com> <20231030063904.2116277-3-xiao.w.wang@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3v+8nSO/BFqyKTLR" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --3v+8nSO/BFqyKTLR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > > > +static __always_inline unsigned long variable__ffs(unsigned long w= ord) > > > > +{ > > > > + int num; > > > > + > > > > + asm_volatile_goto( > > > > + ALTERNATIVE("j %l[legacy]", "nop", 0, RISCV_ISA_EXT_ZBB, 1) > > > > + : : : : legacy); > > > > + > > >=20 > > > On this and following asm blocks, checkpatch outputs: "Lines should = not > > > end with a '('". > >=20 > > I did below check, but I got no warning. > > # ./scripts/checkpatch.pl v4-0002-riscv-Optimize-bitops-with-Zbb-extens= ion.patch > > total: 0 errors, 0 warnings, 280 lines checked > > May I know how you do the check? > > BTW, I see arch/riscv/include/asm/jump_label.h and arch/riscv/include/a= sm/cpufeature.h have similar code. >=20 > I normally use the --strict flag since that is what the Patchwork server > uses. FWIW, checkpatch output does require human interpretation. It is only a "dumb" perl script, and particularly for asm stuff the complaints can often be ignored. IMO, this is one of those times. --3v+8nSO/BFqyKTLR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZUCyTgAKCRB4tDGHoIJi 0lb5AQCTfhMacWVDaEEfgJBvcrswUdOTbdqr3jTISqjE8bOYMgD+IZQdBokuYmL2 ontBt5Lb+1jxFiabOCOk+tl9dAAW5Qs= =HvTx -----END PGP SIGNATURE----- --3v+8nSO/BFqyKTLR--