mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: dimadrumspro@yahoo.com
To: dimadrumspro@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Drivers: comedi: drivers: ssv_dnp: fixed a brace coding style issue
Date: Tue, 31 Oct 2023 17:25:54 +0100	[thread overview]
Message-ID: <20231031162554.4189-1-dimadrumspro@gmail.com> (raw)

From: dimaaac <dimadrumspro@gmail.com>

Fixed a coding style issue, as well as a typo (lowercased word)
and removed unnecessary filename comment.

Signed-off-by: dimaaac <dimadrumspro@gmail.com>
---
 drivers/comedi/drivers/ssv_dnp.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/comedi/drivers/ssv_dnp.c b/drivers/comedi/drivers/ssv_dnp.c
index 813bd0853b0b..d0747767810b 100644
--- a/drivers/comedi/drivers/ssv_dnp.c
+++ b/drivers/comedi/drivers/ssv_dnp.c
@@ -1,7 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0+
 /*
- * ssv_dnp.c
- * generic comedi driver for SSV Embedded Systems' DIL/Net-PCs
+ * Generic comedi driver for SSV Embedded Systems' DIL/Net-PCs
  * Copyright (C) 2001 Robert Schwebel <robert@schwebel.de>
  *
  * COMEDI - Linux Control and Measurement Device Interface
@@ -91,13 +90,13 @@ static int dnp_dio_insn_config(struct comedi_device *dev,
 	if (ret)
 		return ret;
 
-	if (chan < 8) {			/* Port A */
+	if (chan < 8)			/* Port A */
 		mask = 1 << chan;
 		outb(PAMR, CSCIR);
-	} else if (chan < 16) {		/* Port B */
+	else if (chan < 16)		/* Port B */
 		mask = 1 << (chan - 8);
 		outb(PBMR, CSCIR);
-	} else {			/* Port C */
+	else				/* Port C */
 		/*
 		 * We have to pay attention with port C.
 		 * This is the meaning of PCMR:
@@ -109,7 +108,6 @@ static int dnp_dio_insn_config(struct comedi_device *dev,
 		 */
 		mask = 1 << ((chan - 16) * 2);
 		outb(PCMR, CSCIR);
-	}
 
 	val = inb(CSCDR);
 	if (data[0] == COMEDI_OUTPUT)
-- 
2.42.0


             reply	other threads:[~2023-10-31 17:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-31 16:25 dimadrumspro [this message]
2023-10-31 17:19 ` Christophe JAILLET

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231031162554.4189-1-dimadrumspro@gmail.com \
    --to=dimadrumspro@yahoo.com \
    --cc=dimadrumspro@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®