mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: linux-kernel@vger.kernel.org, jbaron@akamai.com,
	gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	intel-gvt-dev@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org
Cc: lb@semihalf.com, linux@rasmusvillemoes.dk, joe@perches.com,
	mcgrof@kernel.org, daniel.vetter@ffwll.ch, jani.nikula@intel.com,
	ville.syrjala@linux.intel.com, seanpaul@chromium.org,
	robdclark@gmail.com, groeck@google.com, yanivt@google.com,
	bleung@google.com, linux-doc@vger.kernel.org,
	quic_saipraka@quicinc.com, will@kernel.org,
	catalin.marinas@arm.com, quic_psodagud@quicinc.com,
	maz@kernel.org, arnd@arndb.de,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, mingo@redhat.com,
	jim.cromie@gmail.com
Subject: [PATCH v7d 18/23] dyndbg: reserve flag bit _DPRINTK_FLAGS_PREFIX_CACHED
Date: Tue, 31 Oct 2023 18:26:04 -0600	[thread overview]
Message-ID: <20231101002609.3533731-19-jim.cromie@gmail.com> (raw)
In-Reply-To: <20231101002609.3533731-1-jim.cromie@gmail.com>

Reserve bit 7 to remember that a pr-debug callsite is/was:
- enabled, with +p
- wants a dynamic-prefix, with one+ of module:function:sourcfile
- was previously called
- was thus saved in the cache. NOT YET.

Its unclear whether any cache fetch would be faster than 2-3 field
fetches, but theres another factor; the 3 columns in the __dyndbg
section are highly redundant and compressible, but to get the
compression, we need field accessors, which will rebalance the
tradeoff.

So, for now, its just the bit reservation.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 include/linux/dynamic_debug.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index 2a7832b1ba5b..4ffddf5e9152 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -38,6 +38,7 @@ struct _ddebug {
 #define _DPRINTK_FLAGS_INCL_LINENO	(1<<3)
 #define _DPRINTK_FLAGS_INCL_TID		(1<<4)
 #define _DPRINTK_FLAGS_INCL_SOURCENAME	(1<<5)
+#define _DPRINTK_FLAGS_PREFIX_CACHED	(1<<7)
 
 #define _DPRINTK_FLAGS_INCL_ANY		\
 	(_DPRINTK_FLAGS_INCL_MODNAME | _DPRINTK_FLAGS_INCL_FUNCNAME |\
-- 
2.41.0


  parent reply	other threads:[~2023-11-01  0:27 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-01  0:25 [PATCH v7d 00/23] fix DRM_USE_DYNAMIC_DEBUG=y regression Jim Cromie
2023-11-01  0:25 ` [PATCH v7d 01/23] test-dyndbg: fixup CLASSMAP usage error Jim Cromie
2023-11-01  0:25 ` [PATCH v7d 02/23] dyndbg: reword "class unknown," to "class:_UNKNOWN_" Jim Cromie
2023-11-01  0:25 ` [PATCH v7d 03/23] dyndbg: make ddebug_class_param union members same size Jim Cromie
2023-11-01  0:25 ` [PATCH v7d 04/23] dyndbg: replace classmap list with a vector Jim Cromie
2023-11-01  0:25 ` [PATCH v7d 05/23] dyndbg: ddebug_apply_class_bitmap - add module arg, select on it Jim Cromie
2023-11-01  0:25 ` [PATCH v7d 06/23] dyndbg: split param_set_dyndbg_classes to module/wrapper fns Jim Cromie
2023-11-01  0:25 ` [PATCH v7d 07/23] dyndbg: drop NUM_TYPE_ARRAY Jim Cromie
2023-11-01  0:25 ` [PATCH v7d 08/23] dyndbg: reduce verbose/debug clutter Jim Cromie
2023-11-01  0:25 ` [PATCH v7d 09/23] dyndbg: silence debugs with no-change updates Jim Cromie
2023-11-01  0:25 ` [PATCH v7d 10/23] dyndbg: tighten ddebug_class_name() 1st arg type Jim Cromie
2023-11-01  0:25 ` [PATCH v7d 11/23] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Jim Cromie
2023-11-01  0:25 ` [PATCH v7d 12/23] dyndbg: reduce verbose=3 messages in ddebug_add_module Jim Cromie
2023-11-01  0:25 ` [PATCH v7d 13/23] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code Jim Cromie
2023-11-01  0:26 ` [PATCH v7d 14/23] dyndbg-API: fix CONFIG_DRM_USE_DYNAMIC_DEBUG regression Jim Cromie
2023-11-01  0:26 ` [PATCH v7d 15/23] dyndbg: refactor ddebug_classparam_clamp_input Jim Cromie
2023-11-01  0:26 ` [PATCH v7d 16/23] dyndbg-API: promote DYNDBG_CLASSMAP_PARAM to API Jim Cromie
2023-11-01  0:26 ` [PATCH v7d 17/23] dyndbg-doc: add classmap info to howto Jim Cromie
2023-11-01  0:26 ` Jim Cromie [this message]
2023-11-01  0:26 ` [PATCH v7d 19/23] dyndbg: add _DPRINTK_FLAGS_INCL_LOOKUP Jim Cromie
2023-11-01  0:26 ` [PATCH v7d 20/23] dyndbg: refactor *dynamic_emit_prefix Jim Cromie
2023-11-01  0:26 ` [PATCH v7d 21/23] drm: use correct ccflags-y spelling Jim Cromie
2023-11-01  0:26 ` [PATCH v7d 22/23] drm-drivers: DRM_CLASSMAP_USE in 2nd batch of drivers, helpers Jim Cromie
2023-11-01  0:26 ` [PATCH v7d 23/23] drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN Jim Cromie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231101002609.3533731-19-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=arnd@arndb.de \
    --cc=bleung@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=groeck@google.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jbaron@akamai.com \
    --cc=joe@perches.com \
    --cc=lb@semihalf.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=maz@kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=mingo@redhat.com \
    --cc=quic_psodagud@quicinc.com \
    --cc=quic_saipraka@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=seanpaul@chromium.org \
    --cc=ville.syrjala@linux.intel.com \
    --cc=will@kernel.org \
    --cc=yanivt@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®