From: Dmitry Rokosov <ddrokosov@salutedevices.com>
To: Conor Dooley <conor@kernel.org>
Cc: <lee@kernel.org>, <pavel@ucw.cz>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<andy.shevchenko@gmail.com>, <kernel@sberdevices.ru>,
<rockosov@gmail.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-leds@vger.kernel.org>
Subject: Re: [PATCH v3 11/11] dt-bindings: leds: aw200xx: fix led pattern and add reg constraints
Date: Wed, 1 Nov 2023 20:48:36 +0300 [thread overview]
Message-ID: <20231101174836.2qlhkgao6pxjjs2e@CAB-WSD-L081021> (raw)
In-Reply-To: <20231101-subzero-grimace-52a10da6a445@spud>
Conor,
On Wed, Nov 01, 2023 at 03:31:28PM +0000, Conor Dooley wrote:
> On Wed, Nov 01, 2023 at 05:24:45PM +0300, Dmitry Rokosov wrote:
> > AW200XX controllers have the capability to declare more than 0xf LEDs,
> > therefore, it is necessary to accept LED names using an appropriate
> > regex pattern.
> >
> > The register offsets can be adjusted within the specified range, with
> > the maximum value corresponding to the highest number of LEDs that can
> > be connected to the controller.
> >
> > Fixes: e338a05e76ca ("dt-bindings: leds: Add binding for AW200xx")
> > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>
>
> You did correctly guess what I was getting at on the previous version.
> Apologies for not replying - I got sick and things probably fell a bit
> through the cracks.
Don't worry! Take care and get well soon!
>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
Should I include this tag in the next version with a fix for the 'reg'
maxItems, or would you review this patch again?
> Cheers,
> Conor.
>
> > ---
> > .../bindings/leds/awinic,aw200xx.yaml | 64 +++++++++++++++++--
> > 1 file changed, 58 insertions(+), 6 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml b/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml
> > index 67c1d960db1d..ba4511664fb8 100644
> > --- a/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml
> > +++ b/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml
> > @@ -45,17 +45,12 @@ properties:
> > maxItems: 1
> >
> > patternProperties:
> > - "^led@[0-9a-f]$":
> > + "^led@[0-9a-f]+$":
> > type: object
> > $ref: common.yaml#
> > unevaluatedProperties: false
> >
> > properties:
> > - reg:
> > - description:
> > - LED number
> > - maxItems: 1
> > -
> > led-max-microamp:
> > default: 9780
> > description: |
> > @@ -69,6 +64,63 @@ patternProperties:
> > where max-current-switch-number is determinated by led configuration
> > and depends on how leds are physically connected to the led driver.
> >
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: awinic,aw20036
> > + then:
> > + patternProperties:
> > + "^led@[0-9a-f]+$":
> > + properties:
> > + reg:
> > + items:
> > + minimum: 0
> > + maximum: 36
> > +
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: awinic,aw20054
> > + then:
> > + patternProperties:
> > + "^led@[0-9a-f]+$":
> > + properties:
> > + reg:
> > + items:
> > + minimum: 0
> > + maximum: 54
> > +
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: awinic,aw20072
> > + then:
> > + patternProperties:
> > + "^led@[0-9a-f]+$":
> > + properties:
> > + reg:
> > + items:
> > + minimum: 0
> > + maximum: 72
> > +
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: awinic,aw20108
> > + then:
> > + patternProperties:
> > + "^led@[0-9a-f]+$":
> > + properties:
> > + reg:
> > + items:
> > + minimum: 0
> > + maximum: 108
> > +
> > required:
> > - compatible
> > - reg
> > --
> > 2.36.0
> >
--
Thank you,
Dmitry
next prev parent reply other threads:[~2023-11-01 17:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 14:24 [PATCH v3 00/11] leds: aw200xx: several driver updates Dmitry Rokosov
2023-11-01 14:24 ` [PATCH v3 01/11] leds: aw200xx: fix write to DIM parameter Dmitry Rokosov
2023-11-01 14:24 ` [PATCH v3 02/11] leds: aw200xx: support HWEN hardware control Dmitry Rokosov
2023-11-01 14:31 ` Dmitry Rokosov
2023-11-01 14:24 ` [PATCH v3 03/11] dt-bindings: leds: aw200xx: introduce optional enable-gpios property Dmitry Rokosov
2023-11-06 14:53 ` Rob Herring
2023-11-01 14:24 ` [PATCH v3 04/11] leds: aw200xx: calculate dts property display_rows in the driver Dmitry Rokosov
2023-11-18 16:46 ` Andy Shevchenko
2023-11-01 14:24 ` [PATCH v3 05/11] dt-bindings: leds: aw200xx: remove property "awinic,display-rows" Dmitry Rokosov
2023-11-01 14:24 ` [PATCH v3 06/11] leds: aw200xx: add delay after software reset Dmitry Rokosov
2023-11-01 14:24 ` [PATCH v3 07/11] leds: aw200xx: enable disable_locking flag in regmap config Dmitry Rokosov
2023-11-01 14:24 ` [PATCH v3 08/11] leds: aw200xx: improve autodim calculation method Dmitry Rokosov
2023-11-01 14:24 ` [PATCH v3 09/11] leds: aw200xx: add support for aw20108 device Dmitry Rokosov
2023-11-01 14:24 ` [PATCH v3 10/11] dt-bindings: leds: awinic,aw200xx: add AW20108 device Dmitry Rokosov
2023-11-01 14:24 ` [PATCH v3 11/11] dt-bindings: leds: aw200xx: fix led pattern and add reg constraints Dmitry Rokosov
2023-11-01 15:31 ` Conor Dooley
2023-11-01 17:48 ` Dmitry Rokosov [this message]
2023-11-01 16:04 ` Rob Herring
2023-11-01 16:17 ` Conor Dooley
2023-11-01 17:44 ` Dmitry Rokosov
2023-11-02 0:17 ` Conor Dooley
2023-11-18 16:57 ` [PATCH v3 00/11] leds: aw200xx: several driver updates Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231101174836.2qlhkgao6pxjjs2e@CAB-WSD-L081021 \
--to=ddrokosov@salutedevices.com \
--cc=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@sberdevices.ru \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rockosov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®