From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9287C4332F for ; Thu, 2 Nov 2023 02:46:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235233AbjKBCqx (ORCPT ); Wed, 1 Nov 2023 22:46:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231574AbjKBCqw (ORCPT ); Wed, 1 Nov 2023 22:46:52 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FD82110 for ; Wed, 1 Nov 2023 19:46:49 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25A4BC433C8; Thu, 2 Nov 2023 02:46:48 +0000 (UTC) Date: Wed, 1 Nov 2023 22:46:46 -0400 From: Steven Rostedt To: "Masami Hiramatsu (Google)" Cc: LKML , Linux Trace Kernel , Mark Rutland , Beau Belgrave Subject: Re: [PATCH] tracing: Have trace_event_file have ref counters Message-ID: <20231101224646.5d9c21fb@gandalf.local.home> In-Reply-To: <20231101223254.7ec2a1e2@gandalf.local.home> References: <20231031122453.7a48b923@gandalf.local.home> <20231102111433.5330cbb98cf204b4063924c0@kernel.org> <20231101223254.7ec2a1e2@gandalf.local.home> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 1 Nov 2023 22:32:54 -0400 Steven Rostedt wrote: > > Ouch! I thought the file descriptor has been hold by the opened process. > > Well, the struct *filp is, but not the filp->private that points to the > struct trace_event_file *file. That was supposed to be "struct file *filp" -- Steve