From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C809C4167B for ; Thu, 2 Nov 2023 10:13:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346153AbjKBKNs (ORCPT ); Thu, 2 Nov 2023 06:13:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345944AbjKBKNq (ORCPT ); Thu, 2 Nov 2023 06:13:46 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F7D5128 for ; Thu, 2 Nov 2023 03:13:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698920024; x=1730456024; h=date:from:to:cc:subject:message-id:mime-version; bh=x5cn2Y24zAHBsyq2rg8rwbDn65TSojQnZdyBbnlFqn0=; b=f7WpMnxaitgPR3ojJcBR8kmTXoAiboc9/2l7lXp286Ola1HzVJ7/DTRY 6c4dVQVlXMpXNK+YZQuJ2W0ZC27leX5m1g5DIkVNsm73TGz7dGzzTDNj5 6iYoX4tazhbns9YL7FW7+N+vlXZFs/7MeB2xInhNkC0ZF9uO4r1j0wjM3 1bua6b35wlknxXD0xD0K2Mo7bE3tNd4YMq/dPaVdeyfARKvbWUuue5+77 y6KM4z/udObUjlHssqyZ7fgS7xvikEpmW5EcNOxeA4kBrJvGwxwICXGxI Pl1hIPZ+jFrncaDxQqyJDvSFBm7BvgPZaUOohx9zzPxqQl/m764FAATX5 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="1550596" X-IronPort-AV: E=Sophos;i="6.03,271,1694761200"; d="scan'208";a="1550596" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2023 03:13:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="796191502" X-IronPort-AV: E=Sophos;i="6.03,271,1694761200"; d="scan'208";a="796191502" Received: from lkp-server01.sh.intel.com (HELO 17d9e85e5079) ([10.239.97.150]) by orsmga001.jf.intel.com with ESMTP; 02 Nov 2023 03:13:42 -0700 Received: from kbuild by 17d9e85e5079 with local (Exim 4.96) (envelope-from ) id 1qyUhn-0001Nr-2i; Thu, 02 Nov 2023 10:13:39 +0000 Date: Thu, 2 Nov 2023 18:13:13 +0800 From: kernel test robot To: Yosry Ahmed Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Alexei Starovoitov , Hao Luo Subject: kernel/cgroup/rstat.c:166:22: warning: no previous declaration for 'bpf_rstat_flush' Message-ID: <202311021859.z3HikNTw-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yosry, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 21e80f3841c01aeaf32d7aee7bbc87b3db1aa0c6 commit: a319185be9f5ad13c2a296d448ac52ffe45d194c cgroup: bpf: enable bpf programs to integrate with rstat date: 1 year, 2 months ago config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20231102/202311021859.z3HikNTw-lkp@intel.com/config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231102/202311021859.z3HikNTw-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202311021859.z3HikNTw-lkp@intel.com/ All warnings (new ones prefixed by >>): >> kernel/cgroup/rstat.c:166:22: warning: no previous declaration for 'bpf_rstat_flush' [-Wmissing-declarations] __weak noinline void bpf_rstat_flush(struct cgroup *cgrp, ^~~~~~~~~~~~~~~ vim +/bpf_rstat_flush +166 kernel/cgroup/rstat.c 147 148 /* 149 * A hook for bpf stat collectors to attach to and flush their stats. 150 * Together with providing bpf kfuncs for cgroup_rstat_updated() and 151 * cgroup_rstat_flush(), this enables a complete workflow where bpf progs that 152 * collect cgroup stats can integrate with rstat for efficient flushing. 153 * 154 * A static noinline declaration here could cause the compiler to optimize away 155 * the function. A global noinline declaration will keep the definition, but may 156 * optimize away the callsite. Therefore, __weak is needed to ensure that the 157 * call is still emitted, by telling the compiler that we don't know what the 158 * function might eventually be. 159 * 160 * __diag_* below are needed to dismiss the missing prototype warning. 161 */ 162 __diag_push(); 163 __diag_ignore_all("-Wmissing-prototypes", 164 "kfuncs which will be used in BPF programs"); 165 > 166 __weak noinline void bpf_rstat_flush(struct cgroup *cgrp, 167 struct cgroup *parent, int cpu) 168 { 169 } 170 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki