From: Klaus Kudielka <klaus.kudielka@gmail.com>
To: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Christian Marangi <ansuelsmth@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Samuel Holland <samuel@sholland.org>,
Jisheng Zhang <jszhang@kernel.org>,
Li Zetao <lizetao1@huawei.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Klaus Kudielka <klaus.kudielka@gmail.com>
Subject: [PATCH] leds: triggers: netdev: add a check, whether device is up
Date: Sat, 4 Nov 2023 13:58:40 +0100 [thread overview]
Message-ID: <20231104125840.27914-1-klaus.kudielka@gmail.com> (raw)
Some net devices do not report NO-CARRIER, if they haven't been brought
up. In that case, the netdev trigger results in a wrong link state being
displayed. Fix this, by adding a check, whether the device is up.
Signed-off-by: Klaus Kudielka <klaus.kudielka@gmail.com>
---
drivers/leds/trigger/ledtrig-netdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/trigger/ledtrig-netdev.c b/drivers/leds/trigger/ledtrig-netdev.c
index e358e77e4b..bd5e21d0f0 100644
--- a/drivers/leds/trigger/ledtrig-netdev.c
+++ b/drivers/leds/trigger/ledtrig-netdev.c
@@ -195,7 +195,8 @@ static void get_device_state(struct led_netdev_data *trigger_data)
{
struct ethtool_link_ksettings cmd;
- trigger_data->carrier_link_up = netif_carrier_ok(trigger_data->net_dev);
+ trigger_data->carrier_link_up = netif_running(trigger_data->net_dev) &&
+ netif_carrier_ok(trigger_data->net_dev);
if (!trigger_data->carrier_link_up)
return;
--
2.42.0
next reply other threads:[~2023-11-04 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-04 12:58 Klaus Kudielka [this message]
2023-11-04 14:29 ` Andrew Lunn
2023-11-04 15:27 ` Klaus Kudielka
2023-11-04 16:32 ` Klaus Kudielka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231104125840.27914-1-klaus.kudielka@gmail.com \
--to=klaus.kudielka@gmail.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=jszhang@kernel.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=pavel@ucw.cz \
--cc=samuel@sholland.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®