From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0460CC4332F for ; Tue, 7 Nov 2023 16:52:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234449AbjKGQws (ORCPT ); Tue, 7 Nov 2023 11:52:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbjKGQwr (ORCPT ); Tue, 7 Nov 2023 11:52:47 -0500 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A80593; Tue, 7 Nov 2023 08:52:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:Mime-Version:Message-Id:Cc:To:From :Date:subject:date:message-id:reply-to; bh=708Ob4ixPn9dXh/UXke39W1GVSQeJllnYess3uXh1ZA=; b=E4JSnKUhDjGltF8QKmpncpoxy2 PKZCMOm5I3PelKbhSCrXOFaOdFEx6Y11eb2Q8AlSNPuKRmusmRFS5nZ7eFMi5WEXiaeU+neieCaqL wmRXd7ocgWP3vUQ+7ALMy5Rl5hTcXmWB1bXFrOAdJqiVkuGP9vdyUig9ZGmCrzDGwu9g=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:44226 helo=pettiford) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1r0PJc-0008Dj-FA; Tue, 07 Nov 2023 11:52:37 -0500 Date: Tue, 7 Nov 2023 11:52:35 -0500 From: Hugo Villeneuve To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Hugo Villeneuve , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-Id: <20231107115235.bc420de600ab7ac5f49102df@hugovil.com> In-Reply-To: References: <20231107160122.1648093-1-hugo@hugovil.com> <8534fc67-83b3-4f41-a1e3-635866e1dd9c@linaro.org> <20231107112804.e854521b47caeafdc642a2f3@hugovil.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com Subject: Re: [PATCH] arm64: dts: imx8mn-var-som: reorder reg properties after compatible strings X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 Nov 2023 17:37:44 +0100 Krzysztof Kozlowski wrote: > On 07/11/2023 17:28, Hugo Villeneuve wrote: > > On Tue, 7 Nov 2023 17:19:20 +0100 > > Krzysztof Kozlowski wrote: > > > >> On 07/11/2023 17:01, Hugo Villeneuve wrote: > >>> From: Hugo Villeneuve > >>> > >>> Move reg nodes after the compatible string, to follow DT conventions. > >> > >> This is a bit of churn... like patches for checkpatch. But unlike > >> checkpatch, it's not even documented. > > > > Hi, > > I do not really understand your point or if I must change > > something... > > > > But looking at a lot of dts, the reg property is always following the > > compatible string, so I assumed it was an undocumented convention or > > best practice... > > > > Patches fixing only checkpatch --strict are usually welcomed only in > staging. But even there no one wants to deal with one patch changing one > style issue in one file. > > You are doing the same, outside of staging, but relying on undocumented > practice. Such patches are unnecessary churn. Documenting the practice > and fixing entire subsystems or groups of devices would be welcomed. > Fixing line by line some style issue is just effort for maintainers. Hi, ok, now it is more clear. I tried to search in Documentation/ or the web for DT conventions/best practices, but couldn't find anything relevant, apart from "use YAML coding style"... Maybe it would be a good thing to add a document for DT best practices eventually... Thank you, Hugo.