From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A47AC4332F for ; Tue, 7 Nov 2023 12:38:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235052AbjKGMiN (ORCPT ); Tue, 7 Nov 2023 07:38:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235178AbjKGMhe (ORCPT ); Tue, 7 Nov 2023 07:37:34 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 572617AB6; Tue, 7 Nov 2023 04:26:08 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BDE42C433CA; Tue, 7 Nov 2023 12:26:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699359967; bh=+qdA2Wuh2OMuSIWrK3Lw7vHqDGosel9VMqwtq536KCk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dGbPfYSFCNDx9QRwYHHgcAbjrT3k8Ym46tM7BypBL8As4lsDcJMhN/C9TKsstzR/W umEENTKt1lg2jvo87qv7Oi0alHMcXNA0RRNvega7bLCa5tULcf6bv8l4ieFiPpjC05 W2n0r9zz4M8eNOfWuILPvyCgRxZZTY1oi4SJFB55YDvjnlNK+jLfwsjNINX/4N4E4T GAbDLT9Z1sjfn9DnAn0KET6XYyYC5TII6cDSIsiZt20rZ4EMC/mXNtVsIZutyUUzsB 9JWKpE1dypeWISo7nHcxjy7w3ct1Gm7wiqYldDBnNZJ09MCBu2LZAEng0r+jOKkb7i sIGBn/uMrpkSg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ma Ke , Alex Deucher , Sasha Levin , christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.5 25/37] drm/radeon: fix a possible null pointer dereference Date: Tue, 7 Nov 2023 07:21:36 -0500 Message-ID: <20231107122407.3760584-25-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231107122407.3760584-1-sashal@kernel.org> References: <20231107122407.3760584-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.5.10 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ma Ke [ Upstream commit 2c1fe3c480f9e1deefd50d4b18be4a046011ee1f ] In radeon_tv_get_modes(), the return value of drm_cvt_mode() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_cvt_mode(). Add a check to avoid null point dereference. Signed-off-by: Ma Ke Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/radeon/radeon_connectors.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c index 07193cd0c4174..4859d965d67e3 100644 --- a/drivers/gpu/drm/radeon/radeon_connectors.c +++ b/drivers/gpu/drm/radeon/radeon_connectors.c @@ -1122,6 +1122,8 @@ static int radeon_tv_get_modes(struct drm_connector *connector) else { /* only 800x600 is supported right now on pre-avivo chips */ tv_mode = drm_cvt_mode(dev, 800, 600, 60, false, false, false); + if (!tv_mode) + return 0; tv_mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; drm_mode_probed_add(connector, tv_mode); } -- 2.42.0