From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAF46C4332F for ; Tue, 7 Nov 2023 16:10:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343718AbjKGQKc (ORCPT ); Tue, 7 Nov 2023 11:10:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344525AbjKGQEF (ORCPT ); Tue, 7 Nov 2023 11:04:05 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23D9C422F; Tue, 7 Nov 2023 07:55:14 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9603C433C9; Tue, 7 Nov 2023 15:55:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699372513; bh=9pVtuYQFcoXUcgBiz25V1/1XHh6haTpQgIZDyAqmX8U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DORqzEcIVYbeaRx8oMhLl/2foFPazPWfVDl3fa52BgQ2CQ+/QqgSSo73+DY3lyj19 qtUDa3dn8SqFm6ufxo4MuMsl5Fe029rCjEPe429JWE6s64cGXcHHn0xeuOaIfu8RV6 Uqf3OtzC0EQ65AzGPitvT546JF59QiCXUE0lH7DUIFHGZDNR86LZsnVpmnzMRkx9jB hVVL0uEk5oh3Qw/2i2uYis+eUOi3kdI00kMB2bHbmfL/RrV5eTIIJbGdWNDqrFXDDp 8mE7HBtu1mt5YvYGDV3He1S3xI51npunisJLIYVLONZ0sFYk1INmZEwzls8pWussHn wDzCI3CSgHFHA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Jonathan Cameron , Dean Luick , Leon Romanovsky , Sasha Levin , dennis.dalessandro@cornelisnetworks.com, linux-rdma@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 2/9] RDMA/hfi1: Use FIELD_GET() to extract Link Width Date: Tue, 7 Nov 2023 10:54:52 -0500 Message-ID: <20231107155509.3769038-2-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231107155509.3769038-1-sashal@kernel.org> References: <20231107155509.3769038-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.14.328 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ilpo Järvinen [ Upstream commit 8bf7187d978610b9e327a3d92728c8864a575ebd ] Use FIELD_GET() to extract PCIe Negotiated Link Width field instead of custom masking and shifting, and remove extract_width() which only wraps that FIELD_GET(). Signed-off-by: Ilpo Järvinen Link: https://lore.kernel.org/r/20230919125648.1920-2-ilpo.jarvinen@linux.intel.com Reviewed-by: Jonathan Cameron Reviewed-by: Dean Luick Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/hw/hfi1/pcie.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/pcie.c b/drivers/infiniband/hw/hfi1/pcie.c index fd9ae23c480ec..c77abf7542e3f 100644 --- a/drivers/infiniband/hw/hfi1/pcie.c +++ b/drivers/infiniband/hw/hfi1/pcie.c @@ -45,6 +45,7 @@ * */ +#include #include #include #include @@ -269,12 +270,6 @@ static u32 extract_speed(u16 linkstat) return speed; } -/* return the PCIe link speed from the given link status */ -static u32 extract_width(u16 linkstat) -{ - return (linkstat & PCI_EXP_LNKSTA_NLW) >> PCI_EXP_LNKSTA_NLW_SHIFT; -} - /* read the link status and set dd->{lbus_width,lbus_speed,lbus_info} */ static void update_lbus_info(struct hfi1_devdata *dd) { @@ -287,7 +282,7 @@ static void update_lbus_info(struct hfi1_devdata *dd) return; } - dd->lbus_width = extract_width(linkstat); + dd->lbus_width = FIELD_GET(PCI_EXP_LNKSTA_NLW, linkstat); dd->lbus_speed = extract_speed(linkstat); snprintf(dd->lbus_info, sizeof(dd->lbus_info), "PCIe,%uMHz,x%u", dd->lbus_speed, dd->lbus_width); -- 2.42.0