From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C275C4332F for ; Wed, 8 Nov 2023 02:49:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343784AbjKHCtd (ORCPT ); Tue, 7 Nov 2023 21:49:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235332AbjKHCtb (ORCPT ); Tue, 7 Nov 2023 21:49:31 -0500 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7425C10F2 for ; Tue, 7 Nov 2023 18:49:29 -0800 (PST) Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1cc5b7057d5so58246025ad.2 for ; Tue, 07 Nov 2023 18:49:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699411769; x=1700016569; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=O0pCvuuqiIXdmKShmtr7TpA+fcjvN0E7H6T0yqECQ54=; b=mkeZv2DnhoIyRbBuK7CY5yaWxHN1s5p+QmDM3BNCpspgzZcv2dMrH/HWZXX29VTovK x/1n39eFc6y/eBLXhRQv1xyABCO7N1Q/CAiLNGbuCC/frkv0SBLvJrIXp/03eRn0AKdR qY1+TBte6iZDKbP8tA+PfsIADvzU1OH1BOkyo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699411769; x=1700016569; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O0pCvuuqiIXdmKShmtr7TpA+fcjvN0E7H6T0yqECQ54=; b=KSIGwYAhmmj4M48rlshum9Jljfyz268xGrkrogStgYzwhbGFMX925F3k7sOJLM/Pva Kjoac1rN5YlqfuBwBeQn8ThIDkSSNfqYnbb4NNOv3x3x27EYE+Ha+Sh0lmQrtJGuu78X 6AARYPeLy6z1hZHMxlV9oi0t624fHZWJrYD5PZsCua7b6Ira1domvjbw/qOT/gYB/bWa nJRmR+tpFpEQxEoc2G6ERYdWOEryjrlCFznrlUkgrqarrf/mFcR7tHxYmegF+XuwVw+K XfG0/V/y84YSJm+VHvKX+WvLJ8DWwPIKObXaMN4ELuHXCgKRiodvZjLLCHZ0E0ZsgIvf 1Jpw== X-Gm-Message-State: AOJu0Yz5TRPbhbv78xmWBWmMMB2XaNwNEpx12ZvuhbqZLEJaItzTjcGv qicApTvyrIWY7lFL/LC5tVmZWQ== X-Google-Smtp-Source: AGHT+IGGCUffSEeIf39+LJitPMsQTTvAdYxDCHBABfr7nE8eOSrRfqBUm7WkSiHgQUm8BjI0viaqaw== X-Received: by 2002:a17:902:b613:b0:1c9:cc88:502c with SMTP id b19-20020a170902b61300b001c9cc88502cmr756838pls.69.1699411768942; Tue, 07 Nov 2023 18:49:28 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:2fe:d436:c346:6fcf]) by smtp.gmail.com with ESMTPSA id j1-20020a170902690100b001c74df14e6esm523291plk.51.2023.11.07.18.49.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Nov 2023 18:49:28 -0800 (PST) Date: Wed, 8 Nov 2023 11:49:24 +0900 From: Sergey Senozhatsky To: Vasily Averin Cc: Sergey Senozhatsky , Minchan Kim , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, zhouxianrong Subject: Re: [PATCH] zram: extra zram_get_element call in zram_read_from_zspool() Message-ID: <20231108024924.GG11577@google.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (23/11/06 22:55), Vasily Averin wrote: > > 'element' and 'handle' are union in struct zram_table_entry. > > Fixes: 8e19d540d107 ("zram: extend zero pages to same element pages") Sorry, what exactly does it fix? [..] > @@ -1318,12 +1318,10 @@ static int zram_read_from_zspool(struct zram *zram, struct page *page, > > handle = zram_get_handle(zram, index); > if (!handle || zram_test_flag(zram, index, ZRAM_SAME)) { > - unsigned long value; > void *mem; > > - value = handle ? zram_get_element(zram, index) : 0; > mem = kmap_atomic(page); > - zram_fill_page(mem, PAGE_SIZE, value); > + zram_fill_page(mem, PAGE_SIZE, handle); > kunmap_atomic(mem); > return 0; > }