From: Jiri Valek - 2N <jiriv@axis.com>
To: <krzysztof.kozlowski+dt@linaro.org>, <dmitry.torokhov@gmail.com>
Cc: <jiriv@axis.com>, <devicetree@vger.kernel.org>,
<linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<robh+dt@kernel.org>, <u.kleine-koenig@pengutronix.de>
Subject: [PATCH v5 3/3] Input: cap11xx - remove unnecessary IRQ parsing
Date: Wed, 8 Nov 2023 16:56:47 +0100 [thread overview]
Message-ID: <20231108155647.1812835-4-jiriv@axis.com> (raw)
In-Reply-To: <20231108155647.1812835-1-jiriv@axis.com>
Separate IRQ parsing is not necessary, I2C core do the job.
Signed-off-by: Jiri Valek - 2N <jiriv@axis.com>
---
drivers/input/keyboard/cap11xx.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/input/keyboard/cap11xx.c b/drivers/input/keyboard/cap11xx.c
index 4711ea985627..ccca9936ef25 100644
--- a/drivers/input/keyboard/cap11xx.c
+++ b/drivers/input/keyboard/cap11xx.c
@@ -518,7 +518,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client)
struct device *dev = &i2c_client->dev;
struct cap11xx_priv *priv;
const struct cap11xx_hw_model *cap;
- int i, error, irq;
+ int i, error;
unsigned int val, rev;
if (id->driver_data >= ARRAY_SIZE(cap11xx_devices)) {
@@ -624,13 +624,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client)
if (error)
return error;
- irq = irq_of_parse_and_map(dev->of_node, 0);
- if (!irq) {
- dev_err(dev, "Unable to parse or map IRQ\n");
- return -ENXIO;
- }
-
- error = devm_request_threaded_irq(dev, irq, NULL, cap11xx_thread_func,
+ error = devm_request_threaded_irq(dev, i2c_client->irq, NULL, cap11xx_thread_func,
IRQF_ONESHOT, dev_name(dev), priv);
if (error)
return error;
--
2.25.1
next prev parent reply other threads:[~2023-11-08 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 15:56 [PATCH v5 0/3] Input: cap11xx add advanced sensitivity settings Jiri Valek - 2N
2023-11-08 15:56 ` [PATCH v5 1/3] dt-bindings: input: microchip,cap11xx: " Jiri Valek - 2N
2023-11-10 8:22 ` Krzysztof Kozlowski
2023-11-16 16:00 ` Jiri Valek - 2N
2023-11-16 17:24 ` Krzysztof Kozlowski
2023-11-08 15:56 ` [PATCH v5 2/3] Input: cap11xx - " Jiri Valek - 2N
2023-11-08 15:56 ` Jiri Valek - 2N [this message]
2023-11-08 19:53 ` [PATCH v5 3/3] Input: cap11xx - remove unnecessary IRQ parsing Rob Herring
2023-11-16 7:43 ` Jiri Valek - 2N
2023-11-17 2:59 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231108155647.1812835-4-jiriv@axis.com \
--to=jiriv@axis.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®