mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
	Masahiro Yamada <masahiroy@kernel.org>
Subject: arch/mips/sgi-ip27/ip27-hubio.c:30: warning: Excess function parameter 'hub' description in 'hub_pio_map'
Date: Fri, 10 Nov 2023 13:59:30 +0800	[thread overview]
Message-ID: <202311101336.BUL1JuvU-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   89cdf9d556016a54ff6ddd62324aa5ec790c05cc
commit: e8a3118e1f5cbe0c26704419390bf074689b349f objtool: make it visible in make V=1 output
date:   7 years ago
config: mips-randconfig-r035-20210927 (https://download.01.org/0day-ci/archive/20231110/202311101336.BUL1JuvU-lkp@intel.com/config)
compiler: mips64-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231110/202311101336.BUL1JuvU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311101336.BUL1JuvU-lkp@intel.com/

All warnings (new ones prefixed by >>):

   arch/mips/sgi-ip27/ip27-hubio.c:30: warning: Function parameter or member 'cnode' not described in 'hub_pio_map'
>> arch/mips/sgi-ip27/ip27-hubio.c:30: warning: Excess function parameter 'hub' description in 'hub_pio_map'


vim +30 arch/mips/sgi-ip27/ip27-hubio.c

^1da177e4c3f41 Linus Torvalds 2005-04-16  18  
^1da177e4c3f41 Linus Torvalds 2005-04-16  19  /**
^1da177e4c3f41 Linus Torvalds 2005-04-16  20   * hub_pio_map	-  establish a HUB PIO mapping
^1da177e4c3f41 Linus Torvalds 2005-04-16  21   *
^1da177e4c3f41 Linus Torvalds 2005-04-16  22   * @hub:	hub to perform PIO mapping on
^1da177e4c3f41 Linus Torvalds 2005-04-16  23   * @widget:	widget ID to perform PIO mapping for
^1da177e4c3f41 Linus Torvalds 2005-04-16  24   * @xtalk_addr: xtalk_address that needs to be mapped
^1da177e4c3f41 Linus Torvalds 2005-04-16  25   * @size:	size of the PIO mapping
^1da177e4c3f41 Linus Torvalds 2005-04-16  26   *
^1da177e4c3f41 Linus Torvalds 2005-04-16  27   **/
^1da177e4c3f41 Linus Torvalds 2005-04-16  28  unsigned long hub_pio_map(cnodeid_t cnode, xwidgetnum_t widget,
^1da177e4c3f41 Linus Torvalds 2005-04-16  29  			  unsigned long xtalk_addr, size_t size)
^1da177e4c3f41 Linus Torvalds 2005-04-16 @30  {
^1da177e4c3f41 Linus Torvalds 2005-04-16  31  	nasid_t nasid = COMPACT_TO_NASID_NODEID(cnode);
^1da177e4c3f41 Linus Torvalds 2005-04-16  32  	unsigned i;
^1da177e4c3f41 Linus Torvalds 2005-04-16  33  
^1da177e4c3f41 Linus Torvalds 2005-04-16  34  	/* use small-window mapping if possible */
^1da177e4c3f41 Linus Torvalds 2005-04-16  35  	if ((xtalk_addr % SWIN_SIZE) + size <= SWIN_SIZE)
^1da177e4c3f41 Linus Torvalds 2005-04-16  36  		return NODE_SWIN_BASE(nasid, widget) + (xtalk_addr % SWIN_SIZE);
^1da177e4c3f41 Linus Torvalds 2005-04-16  37  
^1da177e4c3f41 Linus Torvalds 2005-04-16  38  	if ((xtalk_addr % BWIN_SIZE) + size > BWIN_SIZE) {
^1da177e4c3f41 Linus Torvalds 2005-04-16  39  		printk(KERN_WARNING "PIO mapping at hub %d widget %d addr 0x%lx"
^1da177e4c3f41 Linus Torvalds 2005-04-16  40  				" too big (%ld)\n",
^1da177e4c3f41 Linus Torvalds 2005-04-16  41  				nasid, widget, xtalk_addr, size);
^1da177e4c3f41 Linus Torvalds 2005-04-16  42  		return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16  43  	}
^1da177e4c3f41 Linus Torvalds 2005-04-16  44  
^1da177e4c3f41 Linus Torvalds 2005-04-16  45  	xtalk_addr &= ~(BWIN_SIZE-1);
^1da177e4c3f41 Linus Torvalds 2005-04-16  46  	for (i = 0; i < HUB_NUM_BIG_WINDOW; i++) {
^1da177e4c3f41 Linus Torvalds 2005-04-16  47  		if (test_and_set_bit(i, hub_data(cnode)->h_bigwin_used))
^1da177e4c3f41 Linus Torvalds 2005-04-16  48  			continue;
^1da177e4c3f41 Linus Torvalds 2005-04-16  49  
^1da177e4c3f41 Linus Torvalds 2005-04-16  50  		/*
^1da177e4c3f41 Linus Torvalds 2005-04-16  51  		 * The code below does a PIO write to setup an ITTE entry.
^1da177e4c3f41 Linus Torvalds 2005-04-16  52  		 *
^1da177e4c3f41 Linus Torvalds 2005-04-16  53  		 * We need to prevent other CPUs from seeing our updated
^1da177e4c3f41 Linus Torvalds 2005-04-16  54  		 * memory shadow of the ITTE (in the piomap) until the ITTE
^1da177e4c3f41 Linus Torvalds 2005-04-16  55  		 * entry is actually set up; otherwise, another CPU might
^1da177e4c3f41 Linus Torvalds 2005-04-16  56  		 * attempt a PIO prematurely.
^1da177e4c3f41 Linus Torvalds 2005-04-16  57  		 *
^1da177e4c3f41 Linus Torvalds 2005-04-16  58  		 * Also, the only way we can know that an entry has been
^1da177e4c3f41 Linus Torvalds 2005-04-16  59  		 * received  by the hub and can be used by future PIO reads/
^1da177e4c3f41 Linus Torvalds 2005-04-16  60  		 * writes is by reading back the ITTE entry after writing it.
^1da177e4c3f41 Linus Torvalds 2005-04-16  61  		 *
^1da177e4c3f41 Linus Torvalds 2005-04-16  62  		 * For these two reasons, we PIO read back the ITTE entry
^1da177e4c3f41 Linus Torvalds 2005-04-16  63  		 * after we write it.
^1da177e4c3f41 Linus Torvalds 2005-04-16  64  		 */
^1da177e4c3f41 Linus Torvalds 2005-04-16  65  		IIO_ITTE_PUT(nasid, i, HUB_PIO_MAP_TO_MEM, widget, xtalk_addr);
e12f47ef1680d8 Ralf Baechle   2011-04-11  66  		(void) HUB_L(IIO_ITTE_GET(nasid, i));
^1da177e4c3f41 Linus Torvalds 2005-04-16  67  
^1da177e4c3f41 Linus Torvalds 2005-04-16  68  		return NODE_BWIN_BASE(nasid, widget) + (xtalk_addr % BWIN_SIZE);
^1da177e4c3f41 Linus Torvalds 2005-04-16  69  	}
^1da177e4c3f41 Linus Torvalds 2005-04-16  70  
^1da177e4c3f41 Linus Torvalds 2005-04-16  71  	printk(KERN_WARNING "unable to establish PIO mapping for at"
^1da177e4c3f41 Linus Torvalds 2005-04-16  72  			" hub %d widget %d addr 0x%lx\n",
^1da177e4c3f41 Linus Torvalds 2005-04-16  73  			nasid, widget, xtalk_addr);
^1da177e4c3f41 Linus Torvalds 2005-04-16  74  	return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16  75  }
^1da177e4c3f41 Linus Torvalds 2005-04-16  76  

:::::: The code at line 30 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2023-11-10 17:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202311101336.BUL1JuvU-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®