From: Charles Mirabile <cmirabil@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, brauner@kernel.org,
viro@zeniv.linux.org.uk, Charles Mirabile <cmirabil@redhat.com>
Subject: [PATCH v1 0/1] fs: Consider capabilities relative to namespace for linkat permission check
Date: Fri, 10 Nov 2023 12:06:14 -0500 [thread overview]
Message-ID: <20231110170615.2168372-1-cmirabil@redhat.com> (raw)
This is a one line change that makes `linkat` aware of namespaces when
checking for capabilities.
As far as I can tell, the call to `capable` in this code dates back to
before the `ns_capable` function existed, so I don't think the author
specifically intended to prefer regular `capable` over `ns_capable`,
and no one has noticed or cared to change it yet... until now!
It is already hard enough to use `linkat` to link temporarily files
into the filesystem without the `/proc` workaround, and when moving
a program that was working fine on bare metal into a container,
I got hung up on this additional snag due to the lack of namespace
awareness in `linkat`.
Charles Mirabile (1):
fs: Consider capabilities relative to namespace for linkat permission
check
fs/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
base-commit: 89cdf9d556016a54ff6ddd62324aa5ec790c05cc
--
2.38.1
next reply other threads:[~2023-11-10 17:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 17:06 Charles Mirabile [this message]
2023-11-10 17:06 ` [PATCH v1 1/1] " Charles Mirabile
2023-11-12 20:14 ` [PATCH v1 0/1] " Christian Brauner
2023-11-13 4:15 ` Charles Mirabile
2023-11-13 17:42 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231110170615.2168372-1-cmirabil@redhat.com \
--to=cmirabil@redhat.com \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®