From: Chen Yu <yu.c.chen@intel.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Juri Lelli <juri.lelli@redhat.com>
Cc: linux-kernel@vger.kernel.org, Chen Yu <yu.c.chen@intel.com>
Subject: [PATCH] sched/fair: Remove unnecessary 'curr' reset for pick_next_entity()
Date: Sat, 11 Nov 2023 23:43:18 +0800 [thread overview]
Message-ID: <20231111154318.87777-1-yu.c.chen@intel.com> (raw)
After commit 4c456c9ad334 ("sched/fair: Remove unused 'curr'
argument from pick_next_entity()"), there is no need to
reset 'curr' to NULL because it will not be used by
pick_next_entity().
Signed-off-by: Chen Yu <yu.c.chen@intel.com>
---
kernel/sched/fair.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 2048138ce54b..ddea1be43710 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -8198,8 +8198,6 @@ static struct task_struct *pick_task_fair(struct rq *rq)
if (curr) {
if (curr->on_rq)
update_curr(cfs_rq);
- else
- curr = NULL;
if (unlikely(check_cfs_rq_runtime(cfs_rq)))
goto again;
@@ -8249,8 +8247,6 @@ pick_next_task_fair(struct rq *rq, struct task_struct *prev, struct rq_flags *rf
if (curr) {
if (curr->on_rq)
update_curr(cfs_rq);
- else
- curr = NULL;
/*
* This call to check_cfs_rq_runtime() will do the
--
2.25.1
reply other threads:[~2023-11-11 15:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231111154318.87777-1-yu.c.chen@intel.com \
--to=yu.c.chen@intel.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®