From: Tree Davies <tdavies@darkphysics.net>
To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Tree Davies <tdavies@darkphysics.net>
Subject: [PATCH 4/7] Staging: rtl8192e: Rename variable bAddBaReqDelayed
Date: Mon, 13 Nov 2023 11:59:07 -0800 [thread overview]
Message-ID: <20231113195910.8423-5-tdavies@darkphysics.net> (raw)
In-Reply-To: <20231113195910.8423-1-tdavies@darkphysics.net>
Rename variable bAddBaReqDelayed to add_ba_req_delayed to fix
checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++++----
drivers/staging/rtl8192e/rtl819x_TS.h | 2 +-
drivers/staging/rtl8192e/rtl819x_TSProc.c | 4 ++--
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 4d51c745e7f2..631c857c508f 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -368,7 +368,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb)
if (*status_code == ADDBA_STATUS_SUCCESS) {
if (pBaParamSet->field.ba_policy == BA_POLICY_DELAYED) {
- ts->bAddBaReqDelayed = true;
+ ts->add_ba_req_delayed = true;
deactivate_ba_entry(ieee, pAdmittedBA);
reason_code = DELBA_REASON_END_BA;
goto OnADDBARsp_Reject;
@@ -381,7 +381,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb)
deactivate_ba_entry(ieee, pAdmittedBA);
activate_ba_entry(pAdmittedBA, *pBaTimeoutVal);
} else {
- ts->bAddBaReqDelayed = true;
+ ts->add_ba_req_delayed = true;
ts->bDisable_AddBa = true;
reason_code = DELBA_REASON_END_BA;
goto OnADDBARsp_Reject;
@@ -454,7 +454,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb)
pTxTs->bUsingBa = false;
pTxTs->add_ba_req_in_progress = false;
- pTxTs->bAddBaReqDelayed = false;
+ pTxTs->add_ba_req_delayed = false;
del_timer_sync(&pTxTs->TsAddBaTimer);
tx_ts_delete_ba(ieee, pTxTs);
}
@@ -514,7 +514,7 @@ void rtllib_ba_setup_timeout(struct timer_list *t)
TxPendingBARecord.timer);
pTxTs->add_ba_req_in_progress = false;
- pTxTs->bAddBaReqDelayed = true;
+ pTxTs->add_ba_req_delayed = true;
pTxTs->TxPendingBARecord.b_valid = false;
}
diff --git a/drivers/staging/rtl8192e/rtl819x_TS.h b/drivers/staging/rtl8192e/rtl819x_TS.h
index 276a50f98781..0bf73b625708 100644
--- a/drivers/staging/rtl8192e/rtl819x_TS.h
+++ b/drivers/staging/rtl8192e/rtl819x_TS.h
@@ -28,7 +28,7 @@ struct tx_ts_record {
struct ba_record TxPendingBARecord;
struct ba_record TxAdmittedBARecord;
u8 add_ba_req_in_progress;
- u8 bAddBaReqDelayed;
+ u8 add_ba_req_delayed;
u8 bUsingBa;
u8 bDisable_AddBa;
struct timer_list TsAddBaTimer;
diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index 62414e7b8879..3a1bb512ca69 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -102,7 +102,7 @@ static void ResetTxTsEntry(struct tx_ts_record *ts)
ResetTsCommonInfo(&ts->TsCommonInfo);
ts->TxCurSeq = 0;
ts->add_ba_req_in_progress = false;
- ts->bAddBaReqDelayed = false;
+ ts->add_ba_req_delayed = false;
ts->bUsingBa = false;
ts->bDisable_AddBa = false;
rtllib_reset_ba_entry(&ts->TxAdmittedBARecord);
@@ -436,7 +436,7 @@ void TsStartAddBaProcess(struct rtllib_device *ieee, struct tx_ts_record *pTxTS)
if (pTxTS->add_ba_req_in_progress == false) {
pTxTS->add_ba_req_in_progress = true;
- if (pTxTS->bAddBaReqDelayed) {
+ if (pTxTS->add_ba_req_delayed) {
netdev_dbg(ieee->dev, "Start ADDBA after 60 sec!!\n");
mod_timer(&pTxTS->TsAddBaTimer, jiffies +
msecs_to_jiffies(TS_ADDBA_DELAY));
--
2.39.2
next prev parent reply other threads:[~2023-11-13 19:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 19:59 [PATCH 0/7] Staging: rtl8192e: Rename bool variables Tree Davies
2023-11-13 19:59 ` [PATCH 1/7] Staging: rtl8192e: Rename variable bSendDELBA Tree Davies
2023-11-13 19:59 ` [PATCH 2/7] Staging: rtl8192e: Rename variable bCurrentAMPDUEnable Tree Davies
2023-11-13 19:59 ` [PATCH 3/7] Staging: rtl8192e: Rename variable bAddBaReqInProgress Tree Davies
2023-11-13 19:59 ` Tree Davies [this message]
2023-11-13 19:59 ` [PATCH 5/7] Staging: rtl8192e: Rename variable bUsingBa Tree Davies
2023-11-13 19:59 ` [PATCH 6/7] Staging: rtl8192e: Rename variable bOverwritePending Tree Davies
2023-11-13 19:59 ` [PATCH 7/7] Staging: rtl8192e: Rename variable bDisable_AddBa Tree Davies
2023-11-14 20:09 ` [PATCH 0/7] Staging: rtl8192e: Rename bool variables Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231113195910.8423-5-tdavies@darkphysics.net \
--to=tdavies@darkphysics.net \
--cc=anjan@momi.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®