mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kory Maincent <kory.maincent@bootlin.com>
To: Manivannan Sadhasivam <mani@kernel.org>,
	Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Serge Semin <fancer.lancer@gmail.com>,
	Vinod Koul <vkoul@kernel.org>,
	Cai Huoqing <cai.huoqing@linux.dev>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
	Herve Codina <herve.codina@bootlin.com>,
	Kory Maincent <kory.maincent@bootlin.com>
Subject: [PATCH v5 2/6] dmaengine: dw-edma: Fix wrong interrupt bit set
Date: Tue, 14 Nov 2023 15:51:55 +0100	[thread overview]
Message-ID: <20231114-b4-feature_hdma_mainline-v5-2-7bc86d83c6f7@bootlin.com> (raw)
In-Reply-To: <20231114-b4-feature_hdma_mainline-v5-0-7bc86d83c6f7@bootlin.com>

Fix "HDMA_V0_LOCAL_STOP_INT_EN" to "HDMA_V0_LOCAL_ABORT_INT_EN" as the STOP
bit is already set in the same line.

Fixes: e74c39573d35 ("dmaengine: dw-edma: Add support for native HDMA")
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
---

Changes in v3:
- Split the patch in two to differ bug fix and simple harmless typo.
---
 drivers/dma/dw-edma/dw-hdma-v0-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c
index 1f4cb7db5475..108f9127aaaa 100644
--- a/drivers/dma/dw-edma/dw-hdma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c
@@ -236,7 +236,7 @@ static void dw_hdma_v0_core_start(struct dw_edma_chunk *chunk, bool first)
 		/* Interrupt enable&unmask - done, abort */
 		tmp = GET_CH_32(dw, chan->dir, chan->id, int_setup) |
 		      HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK |
-		      HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_STOP_INT_EN;
+		      HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_ABORT_INT_EN;
 		SET_CH_32(dw, chan->dir, chan->id, int_setup, tmp);
 		/* Channel control */
 		SET_CH_32(dw, chan->dir, chan->id, control1, HDMA_V0_LINKLIST_EN);

-- 
2.25.1


  parent reply	other threads:[~2023-11-14 14:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-14 14:51 [PATCH v5 0/6] Fix support of dw-edma HDMA NATIVE IP in remote setup Kory Maincent
2023-11-14 14:51 ` [PATCH v5 1/6] dmaengine: dw-edma: Fix the ch_count hdma callback Kory Maincent
2023-11-14 14:51 ` Kory Maincent [this message]
2023-11-17  7:48   ` [PATCH v5 2/6] dmaengine: dw-edma: Fix wrong interrupt bit set Manivannan Sadhasivam
2023-11-14 14:51 ` [PATCH v5 3/6] dmaengine: dw-edma: Typo fix Kory Maincent
2023-11-17  7:58   ` Manivannan Sadhasivam
2023-11-14 14:51 ` [PATCH v5 4/6] dmaengine: dw-edma: Add HDMA remote interrupt configuration Kory Maincent
2023-11-14 14:51 ` [PATCH v5 5/6] dmaengine: dw-edma: HDMA: Add sync read before starting the DMA transfer in remote setup Kory Maincent
2023-11-17  8:07   ` Manivannan Sadhasivam
2023-11-14 14:51 ` [PATCH v5 6/6] dmaengine: dw-edma: eDMA: " Kory Maincent
2023-11-17  8:08   ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231114-b4-feature_hdma_mainline-v5-2-7bc86d83c6f7@bootlin.com \
    --to=kory.maincent@bootlin.com \
    --cc=cai.huoqing@linux.dev \
    --cc=dmaengine@vger.kernel.org \
    --cc=fancer.lancer@gmail.com \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=herve.codina@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®