From: Mubin Sayyed <mubin.sayyed@amd.com>
To: <krzysztof.kozlowski+dt@linaro.org>,
<u.kleine-koenig@pengutronix.de>, <thierry.reding@gmail.com>,
<robh+dt@kernel.org>, <conor+dt@kernel.org>, <tglx@linutronix.de>,
<daniel.lezcano@linaro.org>, <michal.simek@amd.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-pwm@vger.kernel.org>, <git@amd.com>, <mubin10@gmail.com>,
Mubin Sayyed <mubin.sayyed@amd.com>
Subject: [LINUX PATCH v2 1/3] clocksource: timer-cadence-ttc: Do not probe TTC device configured as PWM
Date: Tue, 14 Nov 2023 18:17:46 +0530 [thread overview]
Message-ID: <20231114124748.581850-2-mubin.sayyed@amd.com> (raw)
In-Reply-To: <20231114124748.581850-1-mubin.sayyed@amd.com>
TTC device can act either as clocksource/clockevent or
PWM generator, it would be decided by pwm-cells property.
TTC PWM feature would be supported through separate driver
based on PWM framework.
If pwm-cells property is present in TTC node, it would be
treated as PWM device, and clocksource driver should just
skip it.
Signed-off-by: Mubin Sayyed <mubin.sayyed@amd.com>
---
Changes for v2:
- Added comment regarding pwm-cells property
---
drivers/clocksource/timer-cadence-ttc.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/clocksource/timer-cadence-ttc.c b/drivers/clocksource/timer-cadence-ttc.c
index 32daaac9b132..f8fcb1a4bdd0 100644
--- a/drivers/clocksource/timer-cadence-ttc.c
+++ b/drivers/clocksource/timer-cadence-ttc.c
@@ -477,6 +477,13 @@ static int __init ttc_timer_probe(struct platform_device *pdev)
u32 timer_width = 16;
struct device_node *timer = pdev->dev.of_node;
+ /*
+ * If pwm-cells property is present in TTC node,
+ * it would be treated as PWM device.
+ */
+ if (of_property_read_bool(timer, "#pwm-cells"))
+ return -ENODEV;
+
if (initialized)
return 0;
--
2.25.1
next prev parent reply other threads:[~2023-11-14 12:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 12:47 [LINUX PATCH v2 0/3] Add initial support for TTC PWM driver Mubin Sayyed
2023-11-14 12:47 ` Mubin Sayyed [this message]
2023-11-14 21:10 ` [LINUX PATCH v2 1/3] clocksource: timer-cadence-ttc: Do not probe TTC device configured as PWM Krzysztof Kozlowski
2023-11-15 5:55 ` Sayyed, Mubin
2023-11-15 12:11 ` Krzysztof Kozlowski
2023-11-24 11:03 ` Sayyed, Mubin
2023-11-24 11:35 ` Krzysztof Kozlowski
2023-11-24 11:59 ` Michal Simek
2023-11-24 12:07 ` Sayyed, Mubin
2023-11-24 16:24 ` Krzysztof Kozlowski
2023-11-24 16:29 ` Krzysztof Kozlowski
2023-11-14 12:47 ` [LINUX PATCH v2 2/3] dt-bindings: timer: Add bindings for TTC PWM Mubin Sayyed
2023-11-14 21:08 ` Krzysztof Kozlowski
2023-11-14 12:47 ` [LINUX PATCH v2 3/3] pwm: pwm-cadence: Add support " Mubin Sayyed
2023-11-14 21:59 ` Uwe Kleine-König
2023-11-24 11:34 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231114124748.581850-2-mubin.sayyed@amd.com \
--to=mubin.sayyed@amd.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=mubin10@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®