From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59849C47072 for ; Wed, 15 Nov 2023 02:58:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234320AbjKOC6S convert rfc822-to-8bit (ORCPT ); Tue, 14 Nov 2023 21:58:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbjKOC6P (ORCPT ); Tue, 14 Nov 2023 21:58:15 -0500 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2ADA5D2; Tue, 14 Nov 2023 18:58:09 -0800 (PST) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 4B8517FFB; Wed, 15 Nov 2023 10:57:56 +0800 (CST) Received: from EXMBX172.cuchost.com (172.16.6.92) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 15 Nov 2023 10:57:56 +0800 Received: from localhost.localdomain (202.188.176.82) by EXMBX172.cuchost.com (172.16.6.92) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 15 Nov 2023 10:57:51 +0800 From: Ji Sheng Teoh To: CC: , , , , , , , , , , , Subject: Re: [PATCH v2 2/2] dt-bindings: perf: starfive: Add StarLink PMU Date: Wed, 15 Nov 2023 10:57:17 +0800 Message-ID: <20231115025717.1414288-1-jisheng.teoh@starfivetech.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231114-policy-routing-8df2607e76cf@squawk> References: <20231114-policy-routing-8df2607e76cf@squawk> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [202.188.176.82] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX172.cuchost.com (172.16.6.92) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Nov 2023 17:57:15 +0000 Conor Dooley wrote: > On Tue, Nov 14, 2023 at 10:12:54AM +0800, Ji Sheng Teoh wrote: > > Add device tree binding for StarFive's StarLink PMU (Performance > > Monitor Unit). > > > > Signed-off-by: Ji Sheng Teoh > > --- > > .../bindings/perf/starfive,starlink-pmu.yaml | 46 > > +++++++++++++++++++ 1 file changed, 46 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/perf/starfive,starlink-pmu.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/perf/starfive,starlink-pmu.yaml > > b/Documentation/devicetree/bindings/perf/starfive,starlink-pmu.yaml > > new file mode 100644 index 000000000000..b164f6849055 --- /dev/null > > +++ > > b/Documentation/devicetree/bindings/perf/starfive,starlink-pmu.yaml > > @@ -0,0 +1,46 @@ +# SPDX-License-Identifier: GPL-2.0-only OR > > BSD-2-Clause +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/perf/starfive,starlink-pmu.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: StarFive StarLink PMU > > + > > +maintainers: > > + - Ji Sheng Teoh > > + > > +description: > > + StarFive's StarLink PMU integrates one or more CPU cores with a > > shared L3 > > + memory system. The PMU support overflow interrupt, up to 16 > > programmable > > + 64bit event counters, and an independent 64bit cycle counter. > > + StarLink PMU is accessed via MMIO. > > + > > +properties: > > + compatible: > > + const: starfive,starlink-pmu > > This compatible (in isolation) is far too generic. Please add a device > specific compatible for the device that has this PMU. > > Thanks, > Conor. Thanks Conor, I will fix that in v3. > > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + soc { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + l3_pmu: pmu@12900000 { > > + compatible = "starfive,starlink-pmu"; > > + reg = <0x0 0x12900000 0x0 0x10000>; > > + interrupts = <34>; > > + }; > > + }; > > -- > > 2.25.1 > >