From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE5D2C07548 for ; Wed, 15 Nov 2023 03:43:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234482AbjKODnn (ORCPT ); Tue, 14 Nov 2023 22:43:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234296AbjKODnl (ORCPT ); Tue, 14 Nov 2023 22:43:41 -0500 Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4778CF9 for ; Tue, 14 Nov 2023 19:43:37 -0800 (PST) Date: Tue, 14 Nov 2023 22:43:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1700019815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oE/CSWurLiicfPY7jNcreLfS0lMiBahzo5OXWBs5BIY=; b=Mq49kvTsVZ0V53IicaOp2HFyphi71N9wKj5rj30kNo0qviqaqblrRsz9P5S+qJ/crR1dTE FzAvrf9AUZp2VpKO9wO+SCeg/qGaYSnRGsFGSCu7sPsIdTRfYPTLSgZM43R8VnH+v3UuWY MGOBwfZCFeJIIHtSutGt+iV4SQbyM0M= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Jiapeng Chong Cc: bfoster@redhat.com, linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH] bcachefs: Remove the unused variable journal_flags Message-ID: <20231115034332.ccbluu73bx4ejn5c@moria.home.lan> References: <20231115031329.31138-1-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231115031329.31138-1-jiapeng.chong@linux.alibaba.com> X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 15, 2023 at 11:13:29AM +0800, Jiapeng Chong wrote: > Variable journal_flags is not effectively used, so delete it. > > fs/bcachefs/btree_update_interior.c:1057:11: warning: variable 'journal_flags' set but not used. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7559 > Signed-off-by: Jiapeng Chong > --- > fs/bcachefs/btree_update_interior.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/fs/bcachefs/btree_update_interior.c b/fs/bcachefs/btree_update_interior.c > index 9affcb22d9cb..18e5a75142e9 100644 > --- a/fs/bcachefs/btree_update_interior.c > +++ b/fs/bcachefs/btree_update_interior.c > @@ -1054,7 +1054,6 @@ bch2_btree_update_start(struct btree_trans *trans, struct btree_path *path, > unsigned nr_nodes[2] = { 0, 0 }; > unsigned update_level = level; > enum bch_watermark watermark = flags & BCH_WATERMARK_MASK; > - unsigned journal_flags = 0; > int ret = 0; > u32 restart_count = trans->restart_count; > > @@ -1068,10 +1067,6 @@ bch2_btree_update_start(struct btree_trans *trans, struct btree_path *path, > flags &= ~BCH_WATERMARK_MASK; > flags |= watermark; > > - if (flags & BCH_TRANS_COMMIT_journal_reclaim) > - journal_flags |= JOURNAL_RES_GET_NONBLOCK; > - journal_flags |= watermark; > - > while (1) { > nr_nodes[!!update_level] += 1 + split; > update_level++; > -- > 2.20.1.7.g153144c > Yup, this is a leftover from deleting journal pre-reservations.