From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86B93C197A0 for ; Thu, 16 Nov 2023 07:05:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344819AbjKPHFx (ORCPT ); Thu, 16 Nov 2023 02:05:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229638AbjKPHFw (ORCPT ); Thu, 16 Nov 2023 02:05:52 -0500 Received: from mail.nppct.ru (mail.nppct.ru [195.133.245.4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11AB21B8 for ; Wed, 15 Nov 2023 23:05:46 -0800 (PST) Received: from mail.nppct.ru (localhost [127.0.0.1]) by mail.nppct.ru (Postfix) with ESMTP id 73F881C0D6D for ; Thu, 16 Nov 2023 10:05:43 +0300 (MSK) Authentication-Results: mail.nppct.ru (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=nppct.ru DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nppct.ru; h= content-transfer-encoding:mime-version:x-mailer:message-id:date :date:subject:subject:to:from:from; s=dkim; t=1700118342; x= 1700982343; bh=r+9tuCaKj8z7l88YvQQmxGoZqfy8tYSwR5OFdGbttls=; b=r zZJHm/uSBj9GVJhFwEh0tY9SoO0Y0j3hpO+zfrWwlsXquFDANT3yd+MAW9dqc6xP GSDVKSW0st0qXuqrTo70wP9+FoZ/fXY6mTc9FYRpdHwwqha0cmDc/lFvcB52jw2O nx6RvGsN2h/CXbxMtiQJY8lx7ZyIi2go4R4wVG8Hpo= X-Virus-Scanned: Debian amavisd-new at mail.nppct.ru Received: from mail.nppct.ru ([127.0.0.1]) by mail.nppct.ru (mail.nppct.ru [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ltcwhwVN0syL for ; Thu, 16 Nov 2023 10:05:42 +0300 (MSK) Received: from localhost.localdomain (mail.dev-ai-melanoma.ru [185.130.227.204]) by mail.nppct.ru (Postfix) with ESMTPSA id 09FCF1C0883; Thu, 16 Nov 2023 10:05:41 +0300 (MSK) From: Andrey Shumilin To: Sudip Mukherjee Cc: Andrey Shumilin , linux-kernel@vger.kernel.org, khoroshilov@ispras.ru, ykarpov@ispras.ru, vmerzlyakov@ispras.ru, vefanov@ispras.ru Subject: [PATCH 2/2] procfs.c: Increasing array size Date: Thu, 16 Nov 2023 10:05:36 +0300 Message-Id: <20231116070536.38122-1-shum.sdl@nppct.ru> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The maximum size in bytes of the port->base and port->base_hi variables is 20 bytes per variable, since they are copied in decimal notation. Two more characters are \t and \n. A maximum of 42 bytes can be written to a buffer variable. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Andrey Shumilin --- drivers/parport/procfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/parport/procfs.c b/drivers/parport/procfs.c index bd388560ed59..9b894f7cb581 100644 --- a/drivers/parport/procfs.c +++ b/drivers/parport/procfs.c @@ -117,7 +117,7 @@ static int do_hardware_base_addr(struct ctl_table *table, int write, void *result, size_t *lenp, loff_t *ppos) { struct parport *port = (struct parport *)table->extra1; - char buffer[20]; + char buffer[44]; int len = 0; if (*ppos) { -- 2.30.2