mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: catalin.marinas@arm.com, akpm@linux-foundation.org,
	Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH 0/2] tweak kmemleak report format
Date: Thu, 16 Nov 2023 15:43:16 -0700	[thread overview]
Message-ID: <20231116224318.124209-1-jim.cromie@gmail.com> (raw)

These 2 patches make minor changes to the report:

1st strips "age <increasing>" from output.  This makes the output
idempotent; unchanging until a new leak is reported.

2nd adds the backtrace.checksum to the "backtrace:" line.  This lets a
user see repeats without actually reading the whole backtrace.  So now
the backtrace line looks like this:

  backtrace (ck 603070071):

I surveyed for un-wanted effects upon users:

Syzkaller parses kmemleak in executor/common_linux.h:
static void check_leaks(char** frames, int nframes)

It just counts occurrences of "unreferenced object", specifically it
does not look for "age", nor would it choke on "crc" being added.

github has 3 repos with "kmemleak" mentioned, all are moribund.
gitlab has 0 hits on "kmemleak".


Jim Cromie (2):
  kmemleak: drop (age <increasing>) from leak record
  kmemleak: add checksum to backtrace report

 mm/kmemleak.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

-- 
2.41.0


             reply	other threads:[~2023-11-16 22:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-16 22:43 Jim Cromie [this message]
2023-11-16 22:43 ` [PATCH 1/2] kmemleak: drop (age <increasing>) from leak record Jim Cromie
2023-11-18 17:35   ` Catalin Marinas
2023-11-16 22:43 ` [PATCH 2/2] kmemleak: add checksum to backtrace report Jim Cromie
2023-11-18 17:36   ` Catalin Marinas
2023-11-26  6:44     ` jim.cromie
2023-11-16 23:22 ` [PATCH 0/2] tweak kmemleak report format jim.cromie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231116224318.124209-1-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®