From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3749C197A0 for ; Fri, 17 Nov 2023 07:48:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230180AbjKQHs3 (ORCPT ); Fri, 17 Nov 2023 02:48:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229952AbjKQHs0 (ORCPT ); Fri, 17 Nov 2023 02:48:26 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACA59D4D for ; Thu, 16 Nov 2023 23:48:23 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5431EC433C8; Fri, 17 Nov 2023 07:48:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700207303; bh=ukM1FaZyX2KkvDHmJF4BJ4FC+i2tJ29lL0pzGMHUfQk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J9JVd9eWOdz4JY2OJv1s6OK5arnsvJclV8598sR1djt5tvPp/1IsSO6yf2/Kk5GsW lQ485Rfl4VzCtP6SZiYQQp9r7xIW15o1WYWFdIHdjm1ou7r2maduV/+IBVxyNaYMT+ jhZ6E9312O+fhmgOQesynrkwxot5Q2zRAYBp1H8iOGB+Q8BhUFJqGHiCmL3KcihfLM LamLl/6KSkrV1etAE7pW/vsltr6kuL5GwYRvTTH/ON11Q/uEp9mTLCQ99hth8gO2Z/ HEI1mxxmH/s5fJFlr47KKg257+e1AKePcowTyf6zrz/lNq1OtQEMOSPsaidkI9vJvS py2eLnO+fIm9A== Date: Fri, 17 Nov 2023 13:18:16 +0530 From: Manivannan Sadhasivam To: Kory Maincent Cc: Manivannan Sadhasivam , Gustavo Pimentel , Serge Semin , Vinod Koul , Cai Huoqing , Thomas Petazzoni , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Herve Codina Subject: Re: [PATCH v5 2/6] dmaengine: dw-edma: Fix wrong interrupt bit set Message-ID: <20231117074816.GB10361@thinkpad> References: <20231114-b4-feature_hdma_mainline-v5-0-7bc86d83c6f7@bootlin.com> <20231114-b4-feature_hdma_mainline-v5-2-7bc86d83c6f7@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231114-b4-feature_hdma_mainline-v5-2-7bc86d83c6f7@bootlin.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 14, 2023 at 03:51:55PM +0100, Kory Maincent wrote: Subject should reflect HDMA: "dmaengine: dw-edma: Fix wrong interrupt bit set for HDMA" > Fix "HDMA_V0_LOCAL_STOP_INT_EN" to "HDMA_V0_LOCAL_ABORT_INT_EN" as the STOP > bit is already set in the same line. > How about: "Instead of setting HDMA_V0_LOCAL_ABORT_INT_EN bit, HDMA_V0_LOCAL_STOP_INT_EN bit got set twice, due to which the abort interrupt is not getting generated for HDMA. Fix it by setting the correct interrupt enable bit." > Fixes: e74c39573d35 ("dmaengine: dw-edma: Add support for native HDMA") > Signed-off-by: Kory Maincent With the above changes, Reviewed-by: Manivannan Sadhasivam - Mani > Reviewed-by: Serge Semin > --- > > Changes in v3: > - Split the patch in two to differ bug fix and simple harmless typo. > --- > drivers/dma/dw-edma/dw-hdma-v0-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c > index 1f4cb7db5475..108f9127aaaa 100644 > --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c > +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c > @@ -236,7 +236,7 @@ static void dw_hdma_v0_core_start(struct dw_edma_chunk *chunk, bool first) > /* Interrupt enable&unmask - done, abort */ > tmp = GET_CH_32(dw, chan->dir, chan->id, int_setup) | > HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK | > - HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_STOP_INT_EN; > + HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_ABORT_INT_EN; > SET_CH_32(dw, chan->dir, chan->id, int_setup, tmp); > /* Channel control */ > SET_CH_32(dw, chan->dir, chan->id, control1, HDMA_V0_LINKLIST_EN); > > -- > 2.25.1 > -- மணிவண்ணன் சதாசிவம்