From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0DA7C197A0 for ; Fri, 17 Nov 2023 16:10:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231652AbjKQQKN (ORCPT ); Fri, 17 Nov 2023 11:10:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231793AbjKQQKM (ORCPT ); Fri, 17 Nov 2023 11:10:12 -0500 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48C6A189 for ; Fri, 17 Nov 2023 08:10:07 -0800 (PST) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 0495840E01A4; Fri, 17 Nov 2023 16:10:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 4U9P1q4_ffaT; Fri, 17 Nov 2023 16:10:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1700237402; bh=4l/AX34Xk8xNnGdKcFWHaYBWUllvSpSZLfrnRLTllOY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Twxv6dHpy3SzM+aq6d+bZRAuIvY8zd0jPmeGIpMB8JZwTXx8FseOGkRpkvEeP5v9u qLVqb4iNC8xgAuuaP02DvCC3DxRc4qRHa2RGl6yrHc1YagK6U9I11O56BMaKsQMy4P IFofW/vrpzFYNLpSBFJUmENf0yEV0uyHUE7N70cIzEtLetNOfKCd9p5L5VXBWy1Iun T3oHYe/H92iHuAojhjkOpgG1nozLYkHH9SLNV4FF0ERqwUrkvmZbT4xBOUdkXgBOBN i1/E/QPiP/kqoOWASQsM6KfiAYxpQgABjnjCwPk5RhnX4HFfJwM9XMdLWvYpoxgjhy be5TLHvpNdFAOZi5JM8KpqEgy4fDPAP9xuCP/I6SGu+5jH2umR0ZQVVMqUmx2dyzBk //dyMSM2UwjbkX1xm5+XhAg2NT+IB6F6OwKDZp+K7eXU/UFVY9MIgkkIU0ZPQTfnuU SXP5wD0diKRcwAfUZaEs9SzoLlEnCJsjSgLBtsrhagXkOTjEOX8mHPMLPsArX+6egX BduvBN0P7hpsF1Piy9g+SOvIohYxQsq5SpN33TNeRfF9M4pao8bhDmSdCoqCn0IiZ5 x1IyK8+Va+pygzzY00CwAK1+De4zV1MPEfhEWxtlfjC8ZiOuD8GLl1ItD/5U3isBRp b4yP1TnGLTroUffTbtSJrgIk= Received: from zn.tnic (pd95304da.dip0.t-ipconnect.de [217.83.4.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id E19E640E0030; Fri, 17 Nov 2023 16:09:45 +0000 (UTC) Date: Fri, 17 Nov 2023 17:09:40 +0100 From: Borislav Petkov To: David Howells Cc: Linus Torvalds , kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Christian Brauner , Alexander Viro , Jens Axboe , Christoph Hellwig , Christian Brauner , Matthew Wilcox , David Laight , ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Subject: Re: [linus:master] [iov_iter] c9eec08bac: vm-scalability.throughput -16.9% regression Message-ID: <20231117160940.GGZVeQRLgLjJZXBLE1@fat_crate.local> References: <20231116154406.GDZVY4xmFvRQt0wGGE@fat_crate.local> <202311061616.cd495695-oliver.sang@intel.com> <3865842.1700061614@warthog.procyon.org.uk> <20231115190938.GGZVUXcuUjI3i1JRAB@fat_crate.local> <232440.1700153046@warthog.procyon.org.uk> <864270.1700230337@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <864270.1700230337@warthog.procyon.org.uk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 17, 2023 at 02:12:17PM +0000, David Howells wrote: > Borislav Petkov wrote: > > > Hmm, stupid question: are those results better than without that > > oneliner? > > Without any changes, I see something like: > > iov_kunit_benchmark_bvec: avg 3185 uS, stddev 19 uS > iov_kunit_benchmark_bvec: avg 3186 uS, stddev 9 uS > iov_kunit_benchmark_bvec: avg 3244 uS, stddev 153 uS > iov_kunit_benchmark_bvec_split: avg 3397 uS, stddev 16 uS > iov_kunit_benchmark_bvec_split: avg 3400 uS, stddev 16 uS > iov_kunit_benchmark_bvec_split: avg 3402 uS, stddev 34 uS > iov_kunit_benchmark_kvec: avg 2818 uS, stddev 550 uS > iov_kunit_benchmark_kvec: avg 2906 uS, stddev 21 uS > iov_kunit_benchmark_kvec: avg 2923 uS, stddev 1496 uS > iov_kunit_benchmark_xarray: avg 3564 uS, stddev 6 uS > iov_kunit_benchmark_xarray: avg 3573 uS, stddev 17 uS > iov_kunit_benchmark_xarray: avg 3575 uS, stddev 58 uS > iov_kunit_benchmark_xarray_to_bvec: avg 3929 uS, stddev 9 uS > iov_kunit_benchmark_xarray_to_bvec: avg 3930 uS, stddev 6 uS > iov_kunit_benchmark_xarray_to_bvec: avg 3930 uS, stddev 7 uS Which looks like those added memcpy calls add a lot of overhead due to the mitigations crap. You could verify that if you boot a kernel with the oneliner but add "mitigations=off" on the cmdline. Or profile the workload and check whether the return thunks appear higher in the profile... I'd say. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette