From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DAFCC54FB9 for ; Sun, 19 Nov 2023 17:05:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231435AbjKSRFv (ORCPT ); Sun, 19 Nov 2023 12:05:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231331AbjKSRFu (ORCPT ); Sun, 19 Nov 2023 12:05:50 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6EE9B7; Sun, 19 Nov 2023 09:05:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700413546; x=1731949546; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=E1U/gQflmsw99DNKfasX3Bet2pCG3XvfEbcIg8BGrsc=; b=CLc9otGL5v2HKHFrpcMAw5tlcEvs/ToS3V1tzI6+UMLAWc51hh6QnnXQ 4Es8eALjWK9vfbdqCp4MWLWmUYWXEPXb5aeDeF/KpFnAZOxMJc2VCdHT5 1h7za5VFzerZv3dn1n3hKWTKsXhnaGC+UiE6y6ucP0BcAWiCToVXCQKfA 79YMGh+tJrcZQIbZpFvPhJyFw7q0wJ3BQwnZS1hjiGGsZS1rpz1vSF74K 66KVgFH8ckoGPdT968RysYXha7J7kUCdOtcqpxnGLWwCVeZJYvT9+AYCm UzWg4sRLp2mBJJ50xImI2lpQLXqZeQNyYQSI7JQzCaWI8hPBJeTU/KQxH w==; X-IronPort-AV: E=McAfee;i="6600,9927,10899"; a="391293430" X-IronPort-AV: E=Sophos;i="6.04,210,1695711600"; d="scan'208";a="391293430" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2023 09:05:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,210,1695711600"; d="scan'208";a="7486272" Received: from lkp-server02.sh.intel.com (HELO b8de5498638e) ([10.239.97.151]) by fmviesa002.fm.intel.com with ESMTP; 19 Nov 2023 09:05:43 -0800 Received: from kbuild by b8de5498638e with local (Exim 4.96) (envelope-from ) id 1r4lEU-0005Kv-1e; Sun, 19 Nov 2023 17:05:22 +0000 Date: Mon, 20 Nov 2023 01:04:51 +0800 From: kernel test robot To: Zhang Xiaoxu , zhangxiaoxu5@huawei.com, weiyongjun1@huawei.com, linux-kernel@vger.kernel.org, broonie@kernel.org, rostedt@goodmis.org, mingo@redhat.com, frowand.list@gmail.com, linux-spi@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev Subject: Re: [PATCH v4 -next 2/4] spi: mockup: Add register spi device support Message-ID: <202311200018.xB4hEnZx-lkp@intel.com> References: <20231118104442.861759-3-zhangxiaoxu@huawecloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231118104442.861759-3-zhangxiaoxu@huawecloud.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Zhang, kernel test robot noticed the following build warnings: [auto build test WARNING on next-20231117] url: https://github.com/intel-lab-lkp/linux/commits/Zhang-Xiaoxu/spi-mockup-Add-SPI-controller-testing-driver/20231118-184747 base: next-20231117 patch link: https://lore.kernel.org/r/20231118104442.861759-3-zhangxiaoxu%40huawecloud.com patch subject: [PATCH v4 -next 2/4] spi: mockup: Add register spi device support config: openrisc-allmodconfig (https://download.01.org/0day-ci/archive/20231120/202311200018.xB4hEnZx-lkp@intel.com/config) compiler: or1k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231120/202311200018.xB4hEnZx-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202311200018.xB4hEnZx-lkp@intel.com/ All warnings (new ones prefixed by >>): In function '__target_online', inlined from 'spi_mockup_target_live_store' at drivers/spi/spi-mockup.c:161:9: >> drivers/spi/spi-mockup.c:108:9: warning: 'strncpy' specified bound depends on the length of the source argument [-Wstringop-truncation] 108 | strncpy(info.modalias, target->device_id, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 109 | strlen(target->device_id)); | ~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/spi/spi-mockup.c:108:9: note: length computed here 108 | strncpy(info.modalias, target->device_id, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 109 | strlen(target->device_id)); | ~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/strncpy +108 drivers/spi/spi-mockup.c 87 88 static int __target_online(struct spi_mockup_target *target) 89 { 90 struct spi_board_info info = {0}; 91 struct device *dev; 92 93 if (target->spi) 94 return -EBUSY; 95 96 if (!target->host->pdev) 97 return -ENODEV; 98 99 target->chip = find_first_zero_bit(target->host->bitmap, 100 MOCKUP_CHIPSELECT_MAX); 101 if (target->chip < 0) 102 return target->chip; 103 104 if (target->chip > target->host->num_cs) 105 return -EBUSY; 106 107 info.chip_select = target->chip; > 108 strncpy(info.modalias, target->device_id, 109 strlen(target->device_id)); 110 111 target->spi = spi_new_device(target->host->ctrl, &info); 112 if (!target->spi) 113 return -ENOMEM; 114 115 bitmap_set(target->host->bitmap, target->chip, 1); 116 117 dev = &target->host->ctrl->dev; 118 dev_info(dev, "Instantiated device %s at 0x%02x\n", 119 info.modalias, info.chip_select); 120 121 return 0; 122 } 123 124 static int __target_offline(struct spi_mockup_target *target) 125 { 126 struct device *dev; 127 128 if (!target->spi) 129 return -ENODEV; 130 131 dev = &target->host->ctrl->dev; 132 dev_info(dev, "Deleting device %s at 0x%02hx\n", 133 dev_name(&target->spi->dev), target->chip); 134 135 spi_unregister_device(target->spi); 136 target->spi = NULL; 137 138 bitmap_clear(target->host->bitmap, target->chip, 1); 139 140 141 return 0; 142 } 143 144 static ssize_t 145 spi_mockup_target_live_store(struct config_item *item, 146 const char *buf, size_t len) 147 { 148 struct spi_mockup_target *target = to_spi_mockup_target(item); 149 int ret; 150 bool res; 151 152 ret = kstrtobool(buf, &res); 153 if (ret) 154 return -EINVAL; 155 156 if (!strlen(target->device_id)) 157 return -EINVAL; 158 159 mutex_lock(&target->host->lock); 160 if (res) > 161 ret = __target_online(target); 162 else 163 ret = __target_offline(target); 164 mutex_unlock(&target->host->lock); 165 166 return ret ? ret : len; 167 } 168 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki