From: Namhyung Kim <namhyung@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Ian Rogers <irogers@google.com>,
Kan Liang <kan.liang@linux.intel.com>,
Mingwei Zhang <mizhang@google.com>
Subject: [PATCH 3/3] perf/x86: Add CAP_NO_INTERRUPT for uncore PMUs
Date: Mon, 20 Nov 2023 14:19:32 -0800 [thread overview]
Message-ID: <20231120221932.213710-3-namhyung@kernel.org> (raw)
In-Reply-To: <20231120221932.213710-1-namhyung@kernel.org>
It doesn't support sampling in uncore PMU events. While it's
technically possible to generate interrupts, let's treat it as if it
has no interrupt in order to skip the freq adjust/unthrottling logic
in the timer handler which is only meaningful to sampling events.
Also remove the sampling event check because it'd be done in the general
code in the perf_event_open syscall.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
arch/x86/events/intel/uncore.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/arch/x86/events/intel/uncore.c b/arch/x86/events/intel/uncore.c
index 69043e02e8a7..f7e6228bd1b1 100644
--- a/arch/x86/events/intel/uncore.c
+++ b/arch/x86/events/intel/uncore.c
@@ -744,10 +744,6 @@ static int uncore_pmu_event_init(struct perf_event *event)
if (pmu->func_id < 0)
return -ENOENT;
- /* Sampling not supported yet */
- if (hwc->sample_period)
- return -EINVAL;
-
/*
* Place all uncore events for a particular physical package
* onto a single cpu
@@ -919,7 +915,12 @@ static int uncore_pmu_register(struct intel_uncore_pmu *pmu)
.stop = uncore_pmu_event_stop,
.read = uncore_pmu_event_read,
.module = THIS_MODULE,
- .capabilities = PERF_PMU_CAP_NO_EXCLUDE,
+ /*
+ * It doesn't allow sampling for uncore events, let's
+ * treat the PMU has no interrupts to skip them in the
+ * perf_adjust_freq_unthr_context().
+ */
+ .capabilities = PERF_PMU_CAP_NO_EXCLUDE | PERF_PMU_CAP_NO_INTERRUPT,
.attr_update = pmu->type->attr_update,
};
} else {
--
2.43.0.rc1.413.gea7ed67945-goog
next prev parent reply other threads:[~2023-11-20 22:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 22:19 [PATCH 1/3] perf/core: Update perf_adjust_freq_unthr_context() Namhyung Kim
2023-11-20 22:19 ` [PATCH 2/3] perf/core: Reduce PMU access to adjust sample freq Namhyung Kim
2023-11-21 15:57 ` Liang, Kan
2023-11-20 22:19 ` Namhyung Kim [this message]
2023-11-21 15:59 ` [PATCH 3/3] perf/x86: Add CAP_NO_INTERRUPT for uncore PMUs Liang, Kan
2023-11-21 18:30 ` Namhyung Kim
2023-11-21 19:26 ` Liang, Kan
2023-12-01 20:29 ` Namhyung Kim
2023-11-20 22:41 ` [PATCH 1/3] perf/core: Update perf_adjust_freq_unthr_context() Ian Rogers
2023-11-20 23:23 ` Mingwei Zhang
2023-11-21 18:21 ` Namhyung Kim
2023-11-21 23:01 ` Mingwei Zhang
2023-11-24 0:50 ` Mingwei Zhang
2023-11-21 15:57 ` Liang, Kan
2023-12-02 6:16 ` Mingwei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231120221932.213710-3-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=mizhang@google.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®