mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Qais Yousef <qyousef@layalina.io>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Joel Fernandes <joel@joelfernandes.org>,
	Frederic Weisbecker <frederic@kernel.org>,
	Neeraj Upadhyay <quic_neeraju@quicinc.com>,
	Josh Triplett <josh@joshtriplett.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Zqiang <qiang.zhang1211@gmail.com>,
	Andrea Righi <andrea.righi@canonical.com>,
	John Stultz <jstultz@google.com>,
	linux-kernel@vger.kernel.org, rcu@vger.kernel.org
Subject: Re: [PATCH] rcu: Provide a boot time parameter to enable lazy RCU
Date: Tue, 21 Nov 2023 22:15:56 +0000	[thread overview]
Message-ID: <20231121221556.vtpmboamgszbt3jf@airbuntu> (raw)
In-Reply-To: <8ad4e628-7a88-490c-a54d-df09f851f189@paulmck-laptop>

On 11/22/23 15:26, Paul E. McKenney wrote:

> > Either way; I'll follow what the crowd wants too :-)
> 
> Usually a wise choice.  ;-)
> 
> But I must defer to the people using it.

From Android PoV I'd like to be able to boot with default disabled and allow
people to opt-in. At least for the time being until we have confidence no one
is caught with surprise if this caused unexpected problems.

In the future it might default to on once it gets wider usage and testing.

So having a new Kconfig to DEFAULT_OFF sounds good to me to enable a compile
time switch to pick the default with a boot time to further control.

Which would be my plan for v2 unless I hear another suggestion in the coming
week (where I hope people would have had a chance to look and think about it).

> > No need for the rcu_barrier() then? Only reason why we use the _cb flavour
> 
> The module_param() parameters are processed during early boot, before
> the boot CPU has enabled interrupts.  In fact, before rcu_init()
> is invoked, which is in turn long before the scheduler has started.
> Calling rcu_barrier() that early is not so good for your kernel's
> actuarial statistics.

Ah, I missed that it is done that early.

> 
> I am guessing that the module_param_cb() processing happens somewhat
> later in the kernel's lifetime.


Thanks!

--
Qais Yousef

  reply	other threads:[~2023-11-23 13:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-21 20:53 Qais Yousef
2023-11-22 22:00 ` Paul E. McKenney
2023-11-21 21:44   ` Qais Yousef
2023-11-22 23:26     ` Paul E. McKenney
2023-11-21 22:15       ` Qais Yousef [this message]
2023-11-23 17:42         ` Paul E. McKenney
2023-11-23 18:04           ` Frederic Weisbecker
2023-11-23 18:28             ` Paul E. McKenney
2023-11-23  6:28 ` Andrea Righi
2023-11-21 22:17   ` Qais Yousef

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231121221556.vtpmboamgszbt3jf@airbuntu \
    --to=qyousef@layalina.io \
    --cc=andrea.righi@canonical.com \
    --cc=boqun.feng@gmail.com \
    --cc=frederic@kernel.org \
    --cc=jiangshanlai@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=josh@joshtriplett.org \
    --cc=jstultz@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=paulmck@kernel.org \
    --cc=qiang.zhang1211@gmail.com \
    --cc=quic_neeraju@quicinc.com \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®