From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFE09C61D85 for ; Tue, 21 Nov 2023 14:50:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234796AbjKUOuD (ORCPT ); Tue, 21 Nov 2023 09:50:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234736AbjKUOuB (ORCPT ); Tue, 21 Nov 2023 09:50:01 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7EEFA4 for ; Tue, 21 Nov 2023 06:49:57 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8A6BC433C7; Tue, 21 Nov 2023 14:49:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1700578197; bh=Shfyuu0LFsaf0x/cFRvoygir7hUWkkISScjKC4pM99A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MYHPBhcHtJuX25LjmDot7pPB+yBE2zIPDpiRlDCMhEyllkk8ozP5QcOG1AQlpPI2t 9NS3Q8m7Go7FgJkh8Fc4wkzatxFVLaGV2Tdg8R6DGhwinsqEqb7UNC0x3LEWSa6mE1 +4GQyEO2UbAzb+HrFZuIM/CEeDRbUCQkqlF9fSlI= Date: Tue, 21 Nov 2023 14:58:55 +0100 From: Greg Kroah-Hartman To: Akash Kumar Cc: Thinh Nguyen , Jing Leng , Felipe Balbi , Laurent Pinchart , Pratham =?iso-8859-1?Q?Pratap=A0?= , Jack Pham , Wesley Cheng , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: gadget: uvc: Add framebased frame format support Message-ID: <2023112123-setting-waking-7896@gregkh> References: <20231114112516.2723-1-quic_akakum@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231114112516.2723-1-quic_akakum@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 14, 2023 at 04:55:16PM +0530, Akash Kumar wrote: > Add support for framebased frame format which can be used to support > multiple formats like H264 or H265 other than mjpeg and YUV frames. > > Framebased format is set to H264 by default, which can be updated to > other formats by updating the GUID through guid configfs attribute. > > Also,add UVC 1.5 extension to support H264 format and different camera > controls, adding support for Exposure, Zoom, Pan, tilt. When you say "also" or list different things that are done in a single change, that's a huge hint to divide this up into smaller patches and make it a patch series. Please do that here. thanks, greg k-h