From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFD2EC5AD4C for ; Thu, 23 Nov 2023 15:23:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346063AbjKWPXe (ORCPT ); Thu, 23 Nov 2023 10:23:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346051AbjKWPXa (ORCPT ); Thu, 23 Nov 2023 10:23:30 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9171010C0 for ; Thu, 23 Nov 2023 07:23:35 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BA4CC433C9; Thu, 23 Nov 2023 15:23:33 +0000 (UTC) Date: Thu, 23 Nov 2023 10:23:49 -0500 From: Steven Rostedt To: Heiko Carstens Cc: LKML , Linux Trace Kernel , Masami Hiramatsu , Mark Rutland , Andrew Morton , Ajay Kaher , chinglinyu@google.com, lkp@intel.com, namit@vmware.com, oe-lkp@lists.linux.dev, amakhalov@vmware.com, er.ajay.kaher@gmail.com, srivatsa@csail.mit.edu, tkundu@vmware.com, vsirnapalli@vmware.com, linux-s390@vger.kernel.org Subject: Re: [PATCH v5] eventfs: Remove eventfs_file and just use eventfs_inode Message-ID: <20231123102349.110e4525@gandalf.local.home> In-Reply-To: <20231123112548.9603-A-hca@linux.ibm.com> References: <20231004165007.43d79161@gandalf.local.home> <20231117142335.9674-A-hca@linux.ibm.com> <20231117143829.9674-B-hca@linux.ibm.com> <20231123112548.9603-A-hca@linux.ibm.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 23 Nov 2023 12:25:48 +0100 Heiko Carstens wrote: > So, if it helps (this still happens with Linus' master branch): > > create_dir_dentry() is called with a "struct eventfs_inode *ei" (second > parameter), which points to a data structure where "is_freed" is 1. Then it > looks like create_dir() returned "-EEXIST". And looking at the code this > combination then must lead to d_invalidate() incorrectly being called with > "-EEXIST" as dentry pointer. I haven't looked too much at the error codes, let me do that on Monday (it's currently Turkey weekend here in the US). But could you test this branch: git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git trace/core I have a bunch of fixes in that branch that may fix your issue. I just finished testing it and plan on pushing it to Linus before the next rc release. Thanks! -- Steve > > Now, I have no idea how the code should work, but it is quite obvious that > something is broken :) > > Here the dump of the struct eventfs_inode that was passed to > create_file_dentry() when the crash happened: