From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02015C61D97 for ; Fri, 24 Nov 2023 15:21:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345688AbjKXPVu (ORCPT ); Fri, 24 Nov 2023 10:21:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345491AbjKXPVo (ORCPT ); Fri, 24 Nov 2023 10:21:44 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81E2CC1 for ; Fri, 24 Nov 2023 07:21:51 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1FD1C433C9; Fri, 24 Nov 2023 15:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700839311; bh=LkiNqv5TLRrCYY7WjHKTVSxGQ3WbJ9zRq3lhvDB/w5I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W/9coW4PM7Gn/qWd0DzK4w2XzWyxbcALDAI5l6Vb2vdjqsWYlAtul/n2JQvGF7Dw+ TnnrLfjHc+CfBl588vn97XZvfe81pG0VEKW3urDahIVGfzyJl+NNMPQvcDpwq536bV G4wvoFiR0jBlzzHOjQSV0rcj2GClWAnaxHPRP4sVX0NdAzd7RlOpc1N5hsCkyNFE1h Si4S82K8eiKJLRWLp3naWVPkbUF7M/NivzWBPjOygxZm5Om0Iu88zVZLY845pC+X5S aCd0rn+ZN5BKKygLea38GB1+cbjvhtC0k4mPdyLOv/fXtDTULPpi+Ccn/0/xg+G0Kq OYcW5MMQ48eLA== Date: Fri, 24 Nov 2023 16:21:46 +0100 From: Christian Brauner To: Mark Brown Cc: Shuah Khan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] kselftest/clone3: Make test names for set_tid test stable Message-ID: <20231124-eintagsfliege-brennen-385b1d96defe@brauner> References: <20231115-kselftest-clone3-set-tid-v1-1-c1932591c480@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231115-kselftest-clone3-set-tid-v1-1-c1932591c480@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 15, 2023 at 02:43:02PM +0000, Mark Brown wrote: > The test results reported for the clone3_set_tid tests interact poorly with > automation for running kselftest since the reported test names include TIDs > dynamically allocated at runtime. A lot of automation for running kselftest > will compare runs by looking at the test name to identify if the same test > is being run so changing names make it look like the testsuite has been > updated to include new tests. This makes the results display less clearly > and breaks cases like bisection. > > Address this by providing a brief description of the tests and logging that > along with the stable parameters for the test currently logged. The TIDs > are already logged separately in existing logging except for the final test > which has a new log message added. We also tweak the formatting of the > logging of expected/actual values for clarity. > > There are still issues with the logging of skipped tests (many are simply > not logged at all when skipped and all are logged with different names) but > these are less disruptive since the skips are all based on not being run as > root, a condition likely to be stable for a given test system. > > Signed-off-by: Mark Brown > --- May I already acked this. Not sure, Acked-by: Christian Brauner