From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78446C61DF4 for ; Fri, 24 Nov 2023 20:06:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346081AbjKXUGl (ORCPT ); Fri, 24 Nov 2023 15:06:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232591AbjKXUGi (ORCPT ); Fri, 24 Nov 2023 15:06:38 -0500 Received: from mx1.sberdevices.ru (mx1.sberdevices.ru [37.18.73.165]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76BF3C1; Fri, 24 Nov 2023 12:06:42 -0800 (PST) Received: from p-infra-ksmg-sc-msk01 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id 9A9B3100017; Fri, 24 Nov 2023 23:06:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru 9A9B3100017 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1700856399; bh=aQfpANdqR8i0jcvDWjoWS5rmJofhkdnzVnqRtQ121O4=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type:From; b=vORZ2QvHL23YA5lg/13Jtw6tOJEbYE+jjsgM6aWdOOJ6WpzZZZfE0HqAldkZldcTT W/Bjs+fE/BNpACp2IBsoAhgiV52qeNJUDqgxpIVH16nN0WzcdcXzk4GPea+G8MVPWs n5hmIpqn5o2t4NGF4O2/FM7nhsLCCLkSIe3KSQiK7Sfcz6OtG5/2mj2NuRQRSkghIT d+6+vpQO+6Wl7LyD6+zhUBYDEoAU3abJkNpllkgw/EbqVBAqVO6WUyJ5NmfxmAbjNw NQFm9pWxFLNU/pEBlGB7Yen0+ht4m2gqXIHleDlaygBUuPNebc3EyRie8QXr9zrV7w O37TKbC/MNosw== Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Fri, 24 Nov 2023 23:06:38 +0300 (MSK) Received: from localhost (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 24 Nov 2023 23:06:38 +0300 Date: Fri, 24 Nov 2023 23:06:33 +0300 From: Dmitry Rokosov To: Andrew Morton CC: , , , , , , , , , , Subject: Re: [PATCH v3 0/3] samples: introduce cgroup events listeners Message-ID: <20231124200633.scnct5f7auawsjn2@CAB-WSD-L081021> References: <20231123071945.25811-1-ddrokosov@salutedevices.com> <20231124114230.22ed97e85058dc339947f13f@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231124114230.22ed97e85058dc339947f13f@linux-foundation.org> User-Agent: NeoMutt/20220415 X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 181590 [Nov 24 2023] X-KSMG-AntiSpam-Version: 6.0.0.2 X-KSMG-AntiSpam-Envelope-From: ddrokosov@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 4 0.3.4 720d3c21819df9b72e78f051e300e232316d302a, {Track_E25351}, {Tracking_from_domain_doesnt_match_to}, salutedevices.com:7.1.1;127.0.0.199:7.1.2;p-i-exch-sc-m01.sberdevices.ru:7.1.1,5.0.1;100.64.160.123:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean X-KSMG-LinksScanning: Clean X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/11/24 16:16:00 #22525164 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 24, 2023 at 11:42:30AM -0800, Andrew Morton wrote: > On Thu, 23 Nov 2023 10:19:42 +0300 Dmitry Rokosov wrote: > > > To begin with, this patch series relocates the cgroup example code to > > the samples/cgroup directory, which is the appropriate location for such > > code snippets. > > butbut. Didn't we decide to do s/cgroup/memcg/ throughout? I believe the samples directory should be named "samples/cgroup" instead of "memcg" because the cgroup v1 event listener cannot be renamed to "memcg" due to the common naming of cgroup v1 event_control (this sample uses that control to access eventfd). Additionally, I think it would be a good idea to add the new samples for cgroup helpers in that directory. That's why I have only renamed the new memcg listener. -- Thank you, Dmitry