From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43747C4167B for ; Sun, 26 Nov 2023 11:36:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229689AbjKZLgZ (ORCPT ); Sun, 26 Nov 2023 06:36:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjKZLgW (ORCPT ); Sun, 26 Nov 2023 06:36:22 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66B1E101 for ; Sun, 26 Nov 2023 03:36:29 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FF45C433C7; Sun, 26 Nov 2023 11:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700998589; bh=P2P43SYXv6u+aOpsTU/RQ6/+rVreClZ6o7li0KxB/6Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JjrmWqk1+DbOryXclrK/r7SZdXk3DcsNeTRgHuGdTKdF3l0JVVjN1uOZhuOVwYkcS +a+GVTrx+nGWEd5hLUoG39sYZ6vb6tegM1zNPhkuiNasLtvwbo6GqbUkiEjJJ2y0tl qWySar4H2sguCPv+IDwdPeNPEbqwtyhIe3Al4YF9vHTZ2bgmyYCsZ9a8hFgnuiIsDM zZ9QrD3BDbxiRXKDuzD/6J6eThmgezkopACfr29woOfkXX6jKwlyc8e0Y4rsdQVyBk idLuBpoDOEwkW2K5RnBYWAZvd3//Zi9WOsfThc3N0Um/XX6j3mcDqL6QRNkupsGa0F 7XfwrU9fm3UJw== Date: Sun, 26 Nov 2023 11:36:24 +0000 From: Conor Dooley To: Krzysztof Kozlowski Cc: Jisheng Zhang , Emil Renner Berthing , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH] riscv: dts: starfive: add Milkv Mars board device tree Message-ID: <20231126-attractor-swampland-b1b95bd1322b@spud> References: <20231126100055.1595-1-jszhang@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gYJgPLPFWEYyFUMA" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --gYJgPLPFWEYyFUMA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 26, 2023 at 11:27:20AM +0100, Krzysztof Kozlowski wrote: > On 26/11/2023 11:00, Jisheng Zhang wrote: > > + cpus { >=20 > Board should not bring new CPU nodes. Override by label instead. >=20 >=20 > > + timebase-frequency =3D <4000000>; > > + }; This particular one is widespread, but I am not sure why it is being set on the board level in any of the individual cases. On the platforms where I do know where the frequency for this comes from it is set by the SoC, not the board and so should really be fixed by moving this into $soc.dtsi. I suspect the same is true for the jh7110 and timebase-frequency is not a board-level setting and probably needs the same treatment. Those with more insight into how the clocks on the jh7110 are routed can hopefully advise us here. --gYJgPLPFWEYyFUMA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZWMttwAKCRB4tDGHoIJi 0pICAPoCeTCnmr5Ffb8M9OFyuV+MeSGUq3QE+0enkLN9i+3KygEAqJ0V62Uifzg9 9r6wcYvE7wwFGV7sgZr3x+gCUKUyPgc= =a9J5 -----END PGP SIGNATURE----- --gYJgPLPFWEYyFUMA--