From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: Alexander Usyskin <alexander.usyskin@intel.com>,
Vitaly Lubart <vitaly.lubart@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [char-misc-next 1/2] mei: add check for offline bit in every register access
Date: Mon, 27 Nov 2023 13:38:18 +0000 [thread overview]
Message-ID: <2023112706-abroad-gangway-f7d2@gregkh> (raw)
In-Reply-To: <20231018101024.271437-1-tomas.winkler@intel.com>
On Wed, Oct 18, 2023 at 01:10:23PM +0300, Tomas Winkler wrote:
> From: Vitaly Lubart <vitaly.lubart@intel.com>
>
> Added check for offline in every register access function.
> When offline bit is set the driver should not access any mei hw.
>
> Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> drivers/misc/mei/hw-me.c | 154 +++++++++++++++++++++++++++++++++++++--
> 1 file changed, 146 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/misc/mei/hw-me.c b/drivers/misc/mei/hw-me.c
> index d11a0740b47c96c33591e69a..565da19bb980c845bc2cf3ed 100644
> --- a/drivers/misc/mei/hw-me.c
> +++ b/drivers/misc/mei/hw-me.c
> @@ -58,6 +58,9 @@ static inline void mei_me_reg_write(const struct mei_me_hw *hw,
> */
> static inline u32 mei_me_mecbrw_read(const struct mei_device *dev)
> {
> + if (dev->dev->offline)
> + return 0;
Dropped from my review queue due to lack of response :(
prev parent reply other threads:[~2023-11-27 13:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 10:10 Tomas Winkler
2023-10-18 10:10 ` [char-misc-next 2/2] mei: add empty handlers for ops functions Tomas Winkler
2023-10-21 21:05 ` [char-misc-next 1/2] mei: add check for offline bit in every register access Greg Kroah-Hartman
2023-11-27 13:38 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023112706-abroad-gangway-f7d2@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alexander.usyskin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
--cc=vitaly.lubart@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®