From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A635EC4167B for ; Tue, 28 Nov 2023 00:22:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234122AbjK1AWI (ORCPT ); Mon, 27 Nov 2023 19:22:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233895AbjK1AWG (ORCPT ); Mon, 27 Nov 2023 19:22:06 -0500 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFAEBC1 for ; Mon, 27 Nov 2023 16:22:12 -0800 (PST) Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-6cb4d366248so4076877b3a.0 for ; Mon, 27 Nov 2023 16:22:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1701130932; x=1701735732; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FcF7EbG17wMf5A1vywn815C2rgzGBSTBqW3p8rKvm+Q=; b=gHW7zeIRSF2utN8brgCdiO6Rlba0fYGpE5dOK8IlsXWocIGrDthTK5MYK0qlDsXkw7 gFpNyvoRmnbTa9zIL+TKPdtU+tCYSBjZCzJl7etvG6bAJe4ozoVqClXacnhoUodVz1en hBAKMVsquMEFYQFKpaTNhfdkxzuY5rGCExqIQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701130932; x=1701735732; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FcF7EbG17wMf5A1vywn815C2rgzGBSTBqW3p8rKvm+Q=; b=jqkYhLlUFbF0R+9YgexiEcYnMaF94mm7oAFzPvbThAookNPXymhKtDQJSRzLrXewbl 7fe3t1u/xVb29QjskRsDIBO293WCae3l/VaPT9VjqTKwSCv4LQwcbkEhywVTaoJWZE45 nMWxDAtKDcF6aYV9YnwMGAtND/jhTO68JeEchoRH3um0b8mP2sSutGsZi4OcmOwf5kT2 Ro4jG6RmXoZSvplK2YRIefy6SPKDmFFLfTfJhDO/44Bx+CbVTm9o8d1RXJtgKseDegCn wIwPanq8JoAiJzJ0YMFcqzyGnh0ON2VSVNZEIT+kxaqzF+gvdyCcZ+EJUv/bP0cMnn32 v/sg== X-Gm-Message-State: AOJu0Yy2WB4BFKXqtsAVvXORNi2//fnl3LoEhdO+GpGi7UgtRxhJ10nw 10vuJmCsBFH5KGRpkoJAqKZ/Hg== X-Google-Smtp-Source: AGHT+IGUgQLH74WqDwY1dXBnMXs3poKbhgyhnJWjJs8YpFTvm4lBIManweCNuXmLfe1LHnljM+TKyg== X-Received: by 2002:a05:6a00:88f:b0:6b3:f29c:dde1 with SMTP id q15-20020a056a00088f00b006b3f29cdde1mr14055045pfj.21.1701130932417; Mon, 27 Nov 2023 16:22:12 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id fh23-20020a056a00391700b006cc02a6d18asm4752811pfb.61.2023.11.27.16.22.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 16:22:11 -0800 (PST) Date: Mon, 27 Nov 2023 16:22:11 -0800 From: Kees Cook To: Johannes Berg Cc: Dmitry Antipov , Alexey Dobriyan , Will Deacon , Kalle Valo , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH] uapi: propagate __struct_group() attributes to the container union Message-ID: <202311271620.B0CB21B@keescook> References: <20231120110607.98956-1-dmantipov@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 24, 2023 at 06:37:14PM +0100, Johannes Berg wrote: > On Mon, 2023-11-20 at 14:05 +0300, Dmitry Antipov wrote: > > Recently the kernel test robot has reported an ARM-specific BUILD_BUG_ON() > > in an old and unmaintained wil6210 wireless driver. > > > > Heh. I guess it wasn't unmaintained enough for someone to touch it and > add struct_group() to it... It needed it since it was using memcpy across fields. But it's been a while since that change happened, so finding this bug now is pretty impressive. :) > > > include/uapi/linux/stddef.h | 2 +- > > > > No idea what tree this should go through, but I guess wireless isn't > appropriate. I'll take it; thanks for the find Dmitry! -- Kees Cook