From: Angus Chen <angus.chen@jaguarmicro.com>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, Angus Chen <angus.chen@jaguarmicro.com>
Subject: [PATCH] genirq: Fix irqs_unhandled in note_interrupt
Date: Tue, 28 Nov 2023 10:10:43 +0800 [thread overview]
Message-ID: <20231128021043.2099-1-angus.chen@jaguarmicro.com> (raw)
Commit 4f27c00bf80f ("Improve behaviour of spurious IRQ detect")
introduced a age of last_unhandled,after irq_count reached 100000,
we set irqs_unhandled = 0,but we didn't clear last_unhandled.
So we can see the print of irq_spurious_proc_show is not consistent.
Like below:
root@jmkernel:~# cat /proc/irq/138/spurious
count 99998
unhandled 1
last_unhandled 1543930240 ms
root@jmkernel:~# cat /proc/irq/138/spurious
count 0
unhandled 0
last_unhandled 1548915240 ms
we can set last_unhandled=1 as a prompting message.
Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
---
kernel/irq/spurious.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c
index 02b2daf07441..e883df04bdf1 100644
--- a/kernel/irq/spurious.c
+++ b/kernel/irq/spurious.c
@@ -428,7 +428,7 @@ void note_interrupt(struct irq_desc *desc, irqreturn_t action_ret)
mod_timer(&poll_spurious_irq_timer,
jiffies + POLL_SPURIOUS_IRQ_INTERVAL);
}
- desc->irqs_unhandled = 0;
+ desc->irqs_unhandled = 1;
}
bool noirqdebug __read_mostly;
--
2.34.1
next reply other threads:[~2023-11-28 2:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 2:10 Angus Chen [this message]
2024-02-19 15:03 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128021043.2099-1-angus.chen@jaguarmicro.com \
--to=angus.chen@jaguarmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®