From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A73F1C4167B for ; Tue, 28 Nov 2023 08:28:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344035AbjK1I2q (ORCPT ); Tue, 28 Nov 2023 03:28:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229737AbjK1I2o (ORCPT ); Tue, 28 Nov 2023 03:28:44 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AE62F5 for ; Tue, 28 Nov 2023 00:28:51 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1126C433C8; Tue, 28 Nov 2023 08:28:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1701160131; bh=zYAML8pYZVkNA1Zvcok1nkSUd7fnE1Gq5rdjaPq3ww0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tzsig0lxGo6SKlj0UyjU5aDnvHQnK2a3qp8WyigMAXZ9HVhmGGlz+tC4bFvq79Rmr bjZKA3kTHiBeXvn8Q97tAOWHcNKwtpY9P4nPl95lecyvFLDaieG68CVqJX5Hj8o+5t BmR4z6SDCdR/m7thC/Y3tjcnkhBFiVxOg2FyseWM= Date: Tue, 28 Nov 2023 08:28:48 +0000 From: Greg Kroah-Hartman To: Laurent Pinchart Cc: Linus Walleij , Liu Ying , "Rafael J. Wysocki" , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 0/3] Revert panel fixes and original buggy patch Message-ID: <2023112811-abide-oversold-922f@gregkh> References: <20231128-revert-panel-fix-v1-0-69bb05048dae@linaro.org> <20231127232542.GB25590@pendragon.ideasonboard.com> <20231127235244.GD31314@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231127235244.GD31314@pendragon.ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2023 at 01:52:44AM +0200, Laurent Pinchart wrote: > On Tue, Nov 28, 2023 at 12:36:15AM +0100, Linus Walleij wrote: > > On Tue, Nov 28, 2023 at 12:25 AM Laurent Pinchart wrote: > > > On Tue, Nov 28, 2023 at 12:10:18AM +0100, Linus Walleij wrote: > > > > This series reverts the attempts to fix the bug that went > > > > into v6.7-rc1 in commit 199cf07ebd2b > > > > "drm/bridge: panel: Add a device link between drm device and panel device" > > > > and then it reverts that patch as well. > > > > > > > > Signed-off-by: Linus Walleij > > > > --- > > > > Linus Walleij (3): > > > > Revert "driver core: Export device_is_dependent() to modules" > > > > Revert "drm/bridge: panel: Check device dependency before managing device link" > > > > Revert "drm/bridge: panel: Add a device link between drm device and panel device" > > > > > > To preserve bisectability, you should revert in the opposite order. > > > > You mean apply patch 2, then 1, then 3 so the kernel builds after each > > revert? > > > > Yeah that's a good idea, I don't know if I should apply these though, better > > someone else do it since I screwed up too much. > > > > Another option is to just squash the reverts into one, that bisects too :/ > > I thought the commits have been applied to drm-misc in a bisectable > order in the first place, but that doesn't seem to be the case :-( > Reverting "driver core: Export device_is_dependent() to modules" last > seems to be the best option in this case. I wouldn't squash them. Agreed, don't squash, just revert in the opposite order they were applied in originally, that way the tree can always build. thanks, greg k-h