From: Jan Kara <jack@suse.cz>
To: Chao Yu <chao@kernel.org>
Cc: jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Jan Kara <jack@suse.cz>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] f2fs: fix to avoid dirent corruption
Date: Tue, 28 Nov 2023 12:03:01 +0100 [thread overview]
Message-ID: <20231128110301.pk3qbhopptmhvxet@quack3> (raw)
In-Reply-To: <20231128092516.2882629-1-chao@kernel.org>
On Tue 28-11-23 17:25:16, Chao Yu wrote:
> As Al reported in link[1]:
>
> f2fs_rename()
> ...
> if (old_dir != new_dir && !whiteout)
> f2fs_set_link(old_inode, old_dir_entry,
> old_dir_page, new_dir);
> else
> f2fs_put_page(old_dir_page, 0);
>
> You want correct inumber in the ".." link. And cross-directory
> rename does move the source to new parent, even if you'd been asked
> to leave a whiteout in the old place.
>
> [1] https://lore.kernel.org/all/20231017055040.GN800259@ZenIV/
>
> With below testcase, it may cause dirent corruption, due to it missed
> to call f2fs_set_link() to update ".." link to new directory.
> - mkdir -p dir/foo
> - renameat2 -w dir/foo bar
>
> [ASSERT] (__chk_dots_dentries:1421) --> Bad inode number[0x4] for '..', parent parent ino is [0x3]
> [FSCK] other corrupted bugs [Fail]
>
> Fixes: 7e01e7ad746b ("f2fs: support RENAME_WHITEOUT")
> Cc: Jan Kara <jack@suse.cz>
> Reported-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Chao Yu <chao@kernel.org>
Thanks for fixing this! Makes sense to me so feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/f2fs/namei.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
> index 3b1793cfb002..ede6afb81762 100644
> --- a/fs/f2fs/namei.c
> +++ b/fs/f2fs/namei.c
> @@ -1105,7 +1105,7 @@ static int f2fs_rename(struct mnt_idmap *idmap, struct inode *old_dir,
> }
>
> if (old_dir_entry) {
> - if (old_dir != new_dir && !whiteout)
> + if (old_dir != new_dir)
> f2fs_set_link(old_inode, old_dir_entry,
> old_dir_page, new_dir);
> else
> --
> 2.40.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2023-11-28 11:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 9:25 Chao Yu
2023-11-28 11:03 ` Jan Kara [this message]
2023-11-30 18:30 ` [f2fs-dev] " patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128110301.pk3qbhopptmhvxet@quack3 \
--to=jack@suse.cz \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®