From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 273D3C46CA0 for ; Tue, 28 Nov 2023 17:54:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346518AbjK1Ryb (ORCPT ); Tue, 28 Nov 2023 12:54:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234851AbjK1RyY (ORCPT ); Tue, 28 Nov 2023 12:54:24 -0500 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CC6719AC; Tue, 28 Nov 2023 09:54:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DaSxSk00T76/qmCPgVeD4qkkC3Ewg2huSC46XkFQpW0=; b=Kai/m4r7JmROqhB2gxx2uYcqY5 BT2Sa80TbKPKtCutvjTYk9B42PvEvOUIrxjPiGc/eMz1gpg8fqZ4t2MJXAYPRteCCpbvw/lLJhiAn 3pmPz7oj343D6q0v6slZOkbOzPgJFVSPsnxy02S3/yyARh8VVqwLzVOWLmW1DNCQpwTim6z8WTm52 BR6BDtRTD9s0s64jJnf3FtO2tZbtltVdFOYpw8PsjmJYhQWYGZl0NfHbznc/0c8sHHZvwml2PUAAP z5/VwBywP/Y2RtVu7LhYNkm35ak0lS7e72Xnlu3JgMd/X4iE0Gusufsc5MSeIOPGsOLLfwtWzViiv HH8VERrw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1r82Hn-00GgI5-2Z; Tue, 28 Nov 2023 17:54:16 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 0F4033003F0; Tue, 28 Nov 2023 18:54:15 +0100 (CET) Date: Tue, 28 Nov 2023 18:54:14 +0100 From: Peter Zijlstra To: Elliot Berman Cc: "Aiqun(Maria) Yu" , "Rafael J. Wysocki" , Pavel Machek , Ingo Molnar , linux-arm-msm@vger.kernel.org, Pavan Kondeti , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Abhijeet Dharmapurikar Subject: Re: [PATCH 0/2] freezer,sched: do not restore saved_state of a thawed task Message-ID: <20231128175414.GD3818@noisy.programming.kicks-ass.net> References: <20231120-freezer-state-multiple-thaws-v1-0-f2e1dd7ce5a2@quicinc.com> <20231128173119.GC3818@noisy.programming.kicks-ass.net> <8be8ab72-0670-4821-b235-1f8e4ea170b2@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8be8ab72-0670-4821-b235-1f8e4ea170b2@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2023 at 11:33:23AM -0600, Elliot Berman wrote: > > > On 11/28/2023 11:31 AM, Peter Zijlstra wrote: > > On Tue, Nov 28, 2023 at 05:12:00PM +0800, Aiqun(Maria) Yu wrote: > >> On 11/21/2023 1:36 AM, Elliot Berman wrote: > >>> This series applies couple fixes to commit 8f0eed4a78a8 ("freezer,sched: > >>> Use saved_state to reduce some spurious wakeups") which was found while > >>> testing with legacy cgroup freezer. My original testing was only with > >>> system-wide freezer. We found that thaw_task could be called on a task > >>> which was already frozen. Prior to commit 8f0eed4a78a8 ("freezer,sched: > >>> Use saved_state to reduce some spurious wakeups"), this wasn't an issue > >>> as kernel would try to wake up TASK_FROZEN, which wouldn't match the > >>> thawed task state, and no harm done to task. After commit 8f0eed4a78a8 > >>> ("freezer,sched: Use saved_state to reduce some spurious wakeups"), it > >>> was possible to overwrite the state of thawed task. > >>> > >>> To: Rafael J. Wysocki > >>> To: Pavel Machek > >>> To: Ingo Molnar > >>> To: Peter Zijlstra (Intel) > >>> Cc: > >>> Cc: Pavan Kondeti > >>> Cc: Aiqun Yu (Maria) > >>> Cc: > >>> Cc: > >>> Signed-off-by: Elliot Berman > >> Shall we add Fixed tag and Cc: stable@vger.kernel.org ? > >> Since it is fixing a stable user thread hung issue. > > > > If you want this routed through urgent, then yes. > > Fixes tag is added to https://lore.kernel.org/all/20231120-freezer-state-multiple-thaws-v1-1-f2e1dd7ce5a2@quicinc.com/ > > Is CC'ing stable what triggers routing through urgent? Fixes tag should be enough, lemme go find that other copy then.. so much email :/