From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF577C4167B for ; Tue, 28 Nov 2023 21:17:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376708AbjK1VRH (ORCPT ); Tue, 28 Nov 2023 16:17:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376973AbjK1VQO (ORCPT ); Tue, 28 Nov 2023 16:16:14 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DABDA2D66 for ; Tue, 28 Nov 2023 13:08:51 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E5DEC433AD; Tue, 28 Nov 2023 21:08:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701205731; bh=4XV+uvut0OD24gODkknEsc5TunCYGuGUOYpLn49RsNc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lZkypQGkJ57zn6gKfQGO/Unwy1lzjeUVfHM9+Q/hkfsjvZXdyT8zfJoIJgN1520KA O6n/wdehzF8B9DcQ9/yr0EV4H+TcRAta1zQhEOA+qP8ijNNT8lGoh4o+MVMApLLR8Q R+rf08c84Fnkr4TZgc5sxXnXxMxd6XThk2EB1Z/cLZWg9YWNQfjgA9yx7NVV+uOamh vCOMVZElcD+7gtsxlxl6KuDrq2NwHgY5E8OY3hPqA4NAJC0hVChEV7T3FDNuu7xU9k z2HljzcUuhpqTLl4fvvjRAGMYAeWVWcWj4cHSFvIxgjYwaut+iOb5Bua0XKxvVNx1K 6LOTBpWuItNwA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ming Lei , Jens Axboe , Sasha Levin , tj@kernel.org, josef@toxicpanda.com, cgroups@vger.kernel.org, linux-block@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 04/15] blk-cgroup: bypass blkcg_deactivate_policy after destroying Date: Tue, 28 Nov 2023 16:08:25 -0500 Message-ID: <20231128210843.876493-4-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231128210843.876493-1-sashal@kernel.org> References: <20231128210843.876493-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.140 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ming Lei [ Upstream commit e63a57303599b17290cd8bc48e6f20b24289a8bc ] blkcg_deactivate_policy() can be called after blkg_destroy_all() returns, and it isn't necessary since blkg_destroy_all has covered policy deactivation. Signed-off-by: Ming Lei Link: https://lore.kernel.org/r/20231117023527.3188627-4-ming.lei@redhat.com Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- block/blk-cgroup.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index 3ee4c1217b636..fd81a73708645 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -425,6 +425,7 @@ static void blkg_destroy_all(struct request_queue *q) { struct blkcg_gq *blkg, *n; int count = BLKG_DESTROY_BATCH_SIZE; + int i; restart: spin_lock_irq(&q->queue_lock); @@ -447,6 +448,18 @@ static void blkg_destroy_all(struct request_queue *q) } } + /* + * Mark policy deactivated since policy offline has been done, and + * the free is scheduled, so future blkcg_deactivate_policy() can + * be bypassed + */ + for (i = 0; i < BLKCG_MAX_POLS; i++) { + struct blkcg_policy *pol = blkcg_policy[i]; + + if (pol) + __clear_bit(pol->plid, q->blkcg_pols); + } + q->root_blkg = NULL; spin_unlock_irq(&q->queue_lock); } -- 2.42.0