From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A584EC07CA9 for ; Tue, 28 Nov 2023 21:16:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376591AbjK1VQg (ORCPT ); Tue, 28 Nov 2023 16:16:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376566AbjK1VPf (ORCPT ); Tue, 28 Nov 2023 16:15:35 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 793DA4ED8 for ; Tue, 28 Nov 2023 13:09:19 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED899C433B7; Tue, 28 Nov 2023 21:09:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701205759; bh=DmUowkl2RiDc8HkSPrZftrC5MhFstkZnNZPrtmGiKps=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IKYcb2kRJTfbJ7RdwVrkJxlHx/+qhlVxb1E58uc6PU4KGyaGNU0Bv3GiRbTKkHozA ZaCuJsU0w5UxM6cJKIaHa2zrYhW3e1qVGY5VlMVX+MPe8sXhpK6Tw0dRjKKlghwSJ7 gzn9kd3jRAK3fvX5o2IEOMxTfYNUynZQ5AumUJ4A/4zw4YYRDnBYlyDfxlESFqYT07 751uEA7sSlOmTPkC7rMmgh/G9UoNmZbjWZ2wSFgsUooKJRfebl08gct1YOw5gSoFdl 0npoVFQ38VZ7dL6c4XL+aXdyKI8rR2FTQ4F2aBCEmbHycV14HjfEjT4v9tqtq54Jzu kGl5Iaf+N1fNg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ming Lei , Changhui Zhong , Jens Axboe , Sasha Levin , tj@kernel.org, josef@toxicpanda.com, cgroups@vger.kernel.org, linux-block@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 02/13] blk-throttle: fix lockdep warning of "cgroup_mutex or RCU read lock required!" Date: Tue, 28 Nov 2023 16:08:56 -0500 Message-ID: <20231128210914.876813-2-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231128210914.876813-1-sashal@kernel.org> References: <20231128210914.876813-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.202 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ming Lei [ Upstream commit 27b13e209ddca5979847a1b57890e0372c1edcee ] Inside blkg_for_each_descendant_pre(), both css_for_each_descendant_pre() and blkg_lookup() requires RCU read lock, and either cgroup_assert_mutex_or_rcu_locked() or rcu_read_lock_held() is called. Fix the warning by adding rcu read lock. Reported-by: Changhui Zhong Signed-off-by: Ming Lei Link: https://lore.kernel.org/r/20231117023527.3188627-2-ming.lei@redhat.com Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- block/blk-throttle.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/blk-throttle.c b/block/blk-throttle.c index c526fdd0a7b90..4bf514a7bd82c 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -1409,6 +1409,7 @@ static void tg_conf_updated(struct throtl_grp *tg, bool global) tg_bps_limit(tg, READ), tg_bps_limit(tg, WRITE), tg_iops_limit(tg, READ), tg_iops_limit(tg, WRITE)); + rcu_read_lock(); /* * Update has_rules[] flags for the updated tg's subtree. A tg is * considered to have rules if either the tg itself or any of its @@ -1436,6 +1437,7 @@ static void tg_conf_updated(struct throtl_grp *tg, bool global) this_tg->latency_target = max(this_tg->latency_target, parent_tg->latency_target); } + rcu_read_unlock(); /* * We're already holding queue_lock and know @tg is valid. Let's -- 2.42.0