From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D184C4167B for ; Wed, 29 Nov 2023 15:38:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343787AbjK2PiG (ORCPT ); Wed, 29 Nov 2023 10:38:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234936AbjK2PiD (ORCPT ); Wed, 29 Nov 2023 10:38:03 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92CA9D67 for ; Wed, 29 Nov 2023 07:38:09 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71B9FC433C7; Wed, 29 Nov 2023 15:38:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701272289; bh=SyJI1koM3ChrX3JfAvIjzNnOMB63jorV18A8rozU04E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h19jTs9r4FzwzHT96ZNDDekE8fzebNbxj3hS7JtSgruoIZLgArNAe+3LFSv4AAppw 9HkUnUxrZ3/h1KA1fdSzzGx73oNDdq3utTF6nQi86EiUVGM6eXIIS1CR1KzN4Ocgq0 D3RlvkNEzE6LgdpheLl3iN/AdbObAXRCR+OJrH4EBT7+gMoOgVlQqQgf6qBiKYqlJ/ TYOv68ES9JA6Cdt3iPz+s5vZUkzx5lM00TOxTTDsgxdp8Jz5drwaJWMnsdQKsRYED1 Rn9PknViP23++toTb21t3HX6h/WWBrmhrvQZD5IOHCtTX3tFCX3OAvDnmp6STnHeZK OE8hqNpZhZemw== Date: Wed, 29 Nov 2023 15:38:04 +0000 From: Conor Dooley To: Thomas Richard Cc: Nishanth Menon , Tero Kristo , Santosh Shilimkar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vignesh Raghavendra , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com, u-kumar1@ti.com Subject: Re: [PATCH 1/5] dt-bindings: arm: keystone: add ti,j7200-sci compatible Message-ID: <20231129-crawling-gaming-76077ed03c57@spud> References: <20231129-j7200-tisci-s2r-v1-0-c1d5964ed574@bootlin.com> <20231129-j7200-tisci-s2r-v1-1-c1d5964ed574@bootlin.com> <20231129-caress-banister-5b5ccbf183e6@spud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9EBarYguRYNMy8wU" Content-Disposition: inline In-Reply-To: <20231129-caress-banister-5b5ccbf183e6@spud> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --9EBarYguRYNMy8wU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 29, 2023 at 03:34:20PM +0000, Conor Dooley wrote: > On Wed, Nov 29, 2023 at 04:31:17PM +0100, Thomas Richard wrote: > > On j7200, during suspend to ram the soc is powered-off. > > At resume requested irqs shall be restored which is a different behavior > > from other platforms. > >=20 > > Signed-off-by: Thomas Richard >=20 > Acked-by: Conor Dooley Un-Acked. Your dts patch contradicts this one. Is the programming model compatible with the existing devices? To be compatible, the existing device only need to support a compatible subset of behaviours. If so, this patch is wrong. If not, then the dts one is. Thanks, Conor. --9EBarYguRYNMy8wU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZWda3AAKCRB4tDGHoIJi 0p3tAP4lUjMdujHJ8+n8CF2yi20ahruH0ivCP/N+J//GBpYR+AEA5HmQtO8ZCbvG a/y8JXzutWlvCpqIVklpt6M7Bc3jbg8= =tma5 -----END PGP SIGNATURE----- --9EBarYguRYNMy8wU--