From: Sibi Sankar <quic_sibis@quicinc.com>
To: <sudeep.holla@arm.com>, <cristian.marussi@arm.com>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<quic_mdtipton@quicinc.com>,
<linux-arm-kernel@lists.infradead.org>,
<quic_asartor@quicinc.com>, <quic_lingutla@quicinc.com>,
Sibi Sankar <quic_sibis@quicinc.com>
Subject: [PATCH 2/3] firmware: arm_scmi: Fix freq/power truncation in the perf protocol
Date: Wed, 29 Nov 2023 12:27:47 +0530 [thread overview]
Message-ID: <20231129065748.19871-3-quic_sibis@quicinc.com> (raw)
In-Reply-To: <20231129065748.19871-1-quic_sibis@quicinc.com>
Fix frequency and power truncation seen in the performance protocol by
casting it with the correct type.
Fixes: a9e3fbfaa0ff ("firmware: arm_scmi: add initial support for performance protocol")
Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
---
drivers/firmware/arm_scmi/perf.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c
index a648521e04a3..3344ce3a2026 100644
--- a/drivers/firmware/arm_scmi/perf.c
+++ b/drivers/firmware/arm_scmi/perf.c
@@ -804,9 +804,9 @@ static int scmi_dvfs_device_opps_add(const struct scmi_protocol_handle *ph,
for (idx = 0; idx < dom->opp_count; idx++) {
if (!dom->level_indexing_mode)
- freq = dom->opp[idx].perf * dom->mult_factor;
+ freq = (unsigned long)dom->opp[idx].perf * dom->mult_factor;
else
- freq = dom->opp[idx].indicative_freq * 1000;
+ freq = (unsigned long)dom->opp[idx].indicative_freq * 1000;
data.level = dom->opp[idx].perf;
data.freq = freq;
@@ -879,7 +879,7 @@ static int scmi_dvfs_freq_get(const struct scmi_protocol_handle *ph, u32 domain,
return ret;
if (!dom->level_indexing_mode) {
- *freq = level * dom->mult_factor;
+ *freq = (unsigned long)level * dom->mult_factor;
} else {
struct scmi_opp *opp;
@@ -887,7 +887,7 @@ static int scmi_dvfs_freq_get(const struct scmi_protocol_handle *ph, u32 domain,
if (!opp)
return -EIO;
- *freq = opp->indicative_freq * 1000;
+ *freq = (unsigned long)opp->indicative_freq * 1000;
}
return ret;
@@ -908,9 +908,9 @@ static int scmi_dvfs_est_power_get(const struct scmi_protocol_handle *ph,
for (opp = dom->opp, idx = 0; idx < dom->opp_count; idx++, opp++) {
if (!dom->level_indexing_mode)
- opp_freq = opp->perf * dom->mult_factor;
+ opp_freq = (unsigned long)opp->perf * dom->mult_factor;
else
- opp_freq = opp->indicative_freq * 1000;
+ opp_freq = (unsigned long)opp->indicative_freq * 1000;
if (opp_freq < *freq)
continue;
--
2.17.1
next prev parent reply other threads:[~2023-11-29 6:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 6:57 [PATCH 0/3] firmware: arm_scmi: Miscellaneous fixes and opp count increase Sibi Sankar
2023-11-29 6:57 ` [PATCH 1/3] firmware: arm_scmi: Fix null pointer dereference during fastchannel init Sibi Sankar
2023-11-30 12:36 ` Cristian Marussi
2023-11-29 6:57 ` Sibi Sankar [this message]
2023-11-30 12:05 ` [PATCH 2/3] firmware: arm_scmi: Fix freq/power truncation in the perf protocol Sudeep Holla
2023-11-30 12:49 ` Cristian Marussi
2023-11-30 13:56 ` Sudeep Holla
2023-11-30 16:25 ` Cristian Marussi
2023-11-30 19:32 ` Sibi Sankar
2023-11-30 20:14 ` Sudeep Holla
2023-11-30 19:51 ` Sudeep Holla
2023-11-29 6:57 ` [PATCH 3/3] firmware: arm_scmi: Increase the maximum opp count Sibi Sankar
2023-11-30 13:00 ` Cristian Marussi
2023-11-30 19:16 ` Sibi Sankar
2023-12-04 13:55 ` (subset) [PATCH 0/3] firmware: arm_scmi: Miscellaneous fixes and opp count increase Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129065748.19871-3-quic_sibis@quicinc.com \
--to=quic_sibis@quicinc.com \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_asartor@quicinc.com \
--cc=quic_lingutla@quicinc.com \
--cc=quic_mdtipton@quicinc.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®