From: Nam Cao <namcao@linutronix.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: broonie@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] spi: introduce SPI_TRANS_FAIL_IO for error reporting
Date: Wed, 29 Nov 2023 15:15:09 +0100 [thread overview]
Message-ID: <20231129141432.ZzaLYucz@linutronix.de> (raw)
In-Reply-To: <CACRpkdZYZUP9rnXbqO1BaHe_e5R8m30sYuPmfhj=VcDS-drZjg@mail.gmail.com>
On Wed, Nov 29, 2023 at 02:55:18PM +0100, Linus Walleij wrote:
> On Wed, Nov 29, 2023 at 2:32 PM Nam Cao <namcao@linutronix.de> wrote:
> > #define SPI_TRANS_FAIL_NO_START BIT(0)
> > +#define SPI_TRANS_FAIL_IO BIT(1)
>
> Is it obvious from context when these flags get set?
> from transfer_one() and in which flag field?
>
> Otherwise maybe we should add a comment.
Agree that the purpose of this flag is not clear. I will add some
description in v2.
Best regards,
Nam
next prev parent reply other threads:[~2023-11-29 14:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 13:32 [PATCH 0/2] spi: spl022: fix sleeping in interrupt context Nam Cao
2023-11-29 13:32 ` [PATCH 1/2] spi: introduce SPI_TRANS_FAIL_IO for error reporting Nam Cao
2023-11-29 13:55 ` Linus Walleij
2023-11-29 14:15 ` Nam Cao [this message]
2023-11-29 13:32 ` [PATCH 2/2] spi: spl022: switch to use default spi_transfer_one_message() Nam Cao
2023-11-29 13:58 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129141432.ZzaLYucz@linutronix.de \
--to=namcao@linutronix.de \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®