From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E62AC4167B for ; Wed, 29 Nov 2023 23:10:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343643AbjK2XK0 (ORCPT ); Wed, 29 Nov 2023 18:10:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343640AbjK2XKY (ORCPT ); Wed, 29 Nov 2023 18:10:24 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E146D7F for ; Wed, 29 Nov 2023 15:10:31 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96778C433C7; Wed, 29 Nov 2023 23:10:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1701299430; bh=N/H0WI8OOAZg5IsWZvaQQHP/VpfSznz5JRrpi05DQq8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YDok8f2518AVgQG+4UbU1jDVslt6EdxIDQcEA9vP/gGtXvaGokTj3clVuawA/cGXw 4aqQWtzWKem2vtw5Ub1sBn+3QvIq/SfJ6ogTJQYOko4tZoMau1Nb4B9Y/lpe+yocnu PEvzSJk+c3KNAvWZP7c0XdWMiPiaqvlDul7kElLw= Date: Wed, 29 Nov 2023 15:10:30 -0800 From: Andrew Morton To: "Arnd Bergmann" Cc: "Stephen Rothwell" , linux-next , "Linux Kernel Mailing List" , "Thomas Bogendoerfer" , "David S. Miller" , sparclinux@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: linux-next: lots of errors/warnings from the -Werror=missing-prototypes addition Message-Id: <20231129151030.24b807f1d2b43be301a533b7@linux-foundation.org> In-Reply-To: References: <20231130075838.05e5bc9b@oak> <20231129131003.d2c1078847c3865c1ac2dfd5@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Nov 2023 23:51:04 +0100 "Arnd Bergmann" wrote: > I did all my testing with CONFIG_WERROR force-enabled, so > the bit I missed here is that at least three architectures > that are missing fixes also set -Werror: mips, sparc and alpha. > > How about adding a patch to no longer force -Werror for > these? These architectures are doing it wrong, aren't they? They should be using the CONFIG_WERROR infrastructure rather than hard-coding it? If so then sure, a standalone patch to clean that up sounds sounds appropriate. I guess it should precede "Makefile.extrawarn: turn on missing-prototypes globally".