From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A3C8C4167B for ; Wed, 29 Nov 2023 20:43:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234084AbjK2UnO (ORCPT ); Wed, 29 Nov 2023 15:43:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231549AbjK2UnM (ORCPT ); Wed, 29 Nov 2023 15:43:12 -0500 Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D44ADD69 for ; Wed, 29 Nov 2023 12:43:18 -0800 (PST) Received: by mail-oi1-x232.google.com with SMTP id 5614622812f47-3b863ec1732so612778b6e.0 for ; Wed, 29 Nov 2023 12:43:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1701290598; x=1701895398; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VQkQZtrQbpqMHU38TIDcUDo5JEq87aQQf1MaJK/f8fE=; b=ltifotaqj3/qFSSn/66l9ZkFHFqhkX08GSxbRrcI48S2PHdWUJbMfSf0gP/VArX6Of 7uOwFjZPGVkdbMgzmqWdvNEFl2u94GDlaphr6YropQ+uAU3bu5h5Y4qrlWbwi6gAAyE1 Ct2P3T87QM76nx+3djrsF0nrht0kKQCN6vmUzjosiGaWfjrPm5o3hcwGhdH3Penmb1wo JyY/sLWAgn5pxuuLL4nimT8jl7vqN7J7gSVGiuMSjocusTrWiYuAiCuw1ytfhrBqX/ZI 4LkBv5yhoAXQlHOpZfGkDo2XkbxW+bIBwNCOwoSuKFGbd7DLM/zgXDvP0ZulnDTGo6Ox CYyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701290598; x=1701895398; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VQkQZtrQbpqMHU38TIDcUDo5JEq87aQQf1MaJK/f8fE=; b=VzfEN7Eute6PlpAuNravhsVhChiRGz057uRSR3NPRLhvO981YIminGa+jnD51t6UeG 9FE3pxObhjsUk8XTCfClGRCn4FH63FuKzi9fDkvRWL2yH3LUBEuE4V6qdSV+IOQ6mhLg sJzDdaA9DXWRTRJ2iCe2KsdFP0SZn1rT2//rin2D8dauS2QhJQ0OA3tdcIeuqD2ADSxC v5JYggdAXQxIeQNd9B1St6OSCbpefhVDQLwAWy8d6MjfPsvw6iKCf3oSKolTOkGqY/a2 tSs9RqT6hHIu0KnAxOWieFhgeLD1vh6ZNr1QoPX2DKjmtJQZDPwuQSUiztuq1TD04Njs 1ekg== X-Gm-Message-State: AOJu0YxZzFAQ7+0Yvs2Ob/+UOj6fCtNmNtN1v2R8QJKST92swrf060Xu +H232uzRveWgxAVLA6Ftqq6H7w== X-Google-Smtp-Source: AGHT+IGLoniM+wElYPIWxSKpX9Eo477s4X8dPUqDwUM2qIN0+StQVm9ol890wMZQ9Fmvg1ybJUuFzw== X-Received: by 2002:a05:6808:152b:b0:3b8:3399:84bf with SMTP id u43-20020a056808152b00b003b8339984bfmr11564700oiw.15.1701290598186; Wed, 29 Nov 2023 12:43:18 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-134-23-187.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.134.23.187]) by smtp.gmail.com with ESMTPSA id bd33-20020a056808222100b003af644e6e81sm1782211oib.45.2023.11.29.12.43.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 12:43:17 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1r8ROv-005pgb-4k; Wed, 29 Nov 2023 16:43:17 -0400 Date: Wed, 29 Nov 2023 16:43:17 -0400 From: Jason Gunthorpe To: Robin Murphy Cc: Joerg Roedel , Christoph Hellwig , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , Paul Walmsley , Palmer Dabbelt , Albert Ou , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Suravee Suthikulpanit , David Woodhouse , Lu Baolu , Niklas Schnelle , Matthew Rosato , Gerald Schaefer , Jean-Philippe Brucker , Rob Herring , Frank Rowand , Marek Szyprowski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, iommu@lists.linux.dev, devicetree@vger.kernel.org Subject: Re: [PATCH 5/7] iommu/dma: Make limit checks self-contained Message-ID: <20231129204317.GQ1312390@ziepe.ca> References: <951f52b59b401418a7ccc00beed15632d1aabd7a.1701268753.git.robin.murphy@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <951f52b59b401418a7ccc00beed15632d1aabd7a.1701268753.git.robin.murphy@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 29, 2023 at 05:43:02PM +0000, Robin Murphy wrote: > It's now easy to retrieve the device's DMA limits if we want to check > them against the domain aperture, so do that ourselves instead of > relying on them being passed through the callchain. > > Signed-off-by: Robin Murphy > --- > drivers/iommu/dma-iommu.c | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) When I spent some time noodling on this a few weeks ago I was looking at putting the dma_range_map_min() effectively as a new reserved region in the common reserved region code so it naturally flows out to all the right places. But this is no worse in that regard than what we have right now: Reviewed-by: Jason Gunthorpe > /* Check the domain allows at least some access to the device... */ > - if (domain->geometry.force_aperture) { > + if (map) { Oh, I've been sitting on a patch to delete force_aperture now too.. Jason