From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: <lee@kernel.org>
Cc: <patches@opensource.cirrus.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mfd: cs42l43: Correct SoundWire port list
Date: Thu, 30 Nov 2023 11:37:21 +0000 [thread overview]
Message-ID: <20231130113721.GT32655@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20231129154230.470705-1-ckeepax@opensource.cirrus.com>
On Wed, Nov 29, 2023 at 03:42:30PM +0000, Charles Keepax wrote:
> Two ports are missing from the port list, and the wrong port is set
> to 4 channels. Also the attempt to list them by function is rather
> misguided, there is nothing in the hardware that fixes a particular
> port to one function. Fix the missing ports, correct the port set to 4
> channels and add a define to get the port mask for each port.
>
> Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
Apologies but scratch this, I am going to flip things around and
just specifying the ports it ends up looking much nicer, new spin
incoming.
Thanks,
Charles
prev parent reply other threads:[~2023-11-30 11:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 15:42 Charles Keepax
2023-11-30 11:37 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130113721.GT32655@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®