mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Donald Robson <donald.robson@imgtec.com>
To: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Cc: <donald.robson@imgtec.com>, <matt.coster@imgtec.com>,
	<frank.binns@imgtec.com>, <boris.brezillon@collabora.com>,
	<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
	<tzimmermann@suse.de>, <airlied@gmail.com>, <daniel@ffwll.ch>,
	Arnd Bergmann <arnd@arndb.de>, kernel test robot <lkp@intel.com>
Subject: [PATCH v2 3/5] drm/imagination: pvr_device_process_active_queues now static
Date: Thu, 30 Nov 2023 16:00:15 +0000	[thread overview]
Message-ID: <20231130160017.259902-3-donald.robson@imgtec.com> (raw)
In-Reply-To: <20231130160017.259902-1-donald.robson@imgtec.com>

The function below is used only within this source file, but is not static.

>> drivers/gpu/drm/imagination/pvr_device.c:129:6: warning: no previous prototype for function 'pvr_device_process_active_queues' [-Wmissing-prototypes]
     129 | void pvr_device_process_active_queues(struct pvr_device *pvr_dev)
         |      ^
   drivers/gpu/drm/imagination/pvr_device.c:129:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     129 | void pvr_device_process_active_queues(struct pvr_device *pvr_dev)
         | ^
         | static 
   1 warning generated.

Make it static.

Reported-by: Arnd Bergmann <arnd@arndb.de>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202311250632.giVEx7MU-lkp@intel.com/
Fixes: c98dab7a5f5f ("drm/imagination: Implement job submission and scheduling")
Signed-off-by: Donald Robson <donald.robson@imgtec.com>
---
 drivers/gpu/drm/imagination/pvr_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/imagination/pvr_device.c b/drivers/gpu/drm/imagination/pvr_device.c
index 8499becf4fbb..048eba776cf2 100644
--- a/drivers/gpu/drm/imagination/pvr_device.c
+++ b/drivers/gpu/drm/imagination/pvr_device.c
@@ -127,7 +127,7 @@ static int pvr_device_clk_init(struct pvr_device *pvr_dev)
  * This is called any time we receive a FW event. It iterates over all
  * active queues and calls pvr_queue_process() on them.
  */
-void pvr_device_process_active_queues(struct pvr_device *pvr_dev)
+static void pvr_device_process_active_queues(struct pvr_device *pvr_dev)
 {
 	struct pvr_queue *queue, *tmp_queue;
 	LIST_HEAD(active_queues);
-- 
2.25.1


  parent reply	other threads:[~2023-11-30 16:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-30 16:00 [PATCH v2 1/5] drm/imagination: Fixed warning due to implicit cast to bool Donald Robson
2023-11-30 16:00 ` [PATCH v2 2/5] drm/imagination: Fixed missing header in pvr_fw_meta Donald Robson
2023-12-01  8:37   ` (subset) " Maxime Ripard
2023-11-30 16:00 ` Donald Robson [this message]
2023-12-01  8:37   ` (subset) [PATCH v2 3/5] drm/imagination: pvr_device_process_active_queues now static Maxime Ripard
2023-11-30 16:00 ` [PATCH v2 4/5] drm/imagination: pvr_gpuvm_free() " Donald Robson
2023-12-01  8:37   ` (subset) " Maxime Ripard
2023-11-30 16:00 ` [PATCH v2 5/5] drm/imagination: Removed unused function to_pvr_vm_gpuva() Donald Robson
2023-12-01  8:37   ` (subset) " Maxime Ripard
2023-12-01  8:37 ` (subset) [PATCH v2 1/5] drm/imagination: Fixed warning due to implicit cast to bool Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231130160017.259902-3-donald.robson@imgtec.com \
    --to=donald.robson@imgtec.com \
    --cc=airlied@gmail.com \
    --cc=arnd@arndb.de \
    --cc=boris.brezillon@collabora.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=frank.binns@imgtec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matt.coster@imgtec.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®