From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68BA7C4167B for ; Fri, 1 Dec 2023 00:45:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377501AbjLAApo (ORCPT ); Thu, 30 Nov 2023 19:45:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377495AbjLAApl (ORCPT ); Thu, 30 Nov 2023 19:45:41 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B218110F0; Thu, 30 Nov 2023 16:45:47 -0800 (PST) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AUNjKNS010401; Fri, 1 Dec 2023 00:45:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=5F9VoOczatYw5XRRZEiVpaQuNwcGVId9T5E3Tu7AbpE=; b=SM2/Uu6U9fFvdvM7f5JgqkRMWmdwoTR79FvRzzoxG6t+W07qvxkA+AP4TBcCY5OJlGe0 Tmx5TWoC/SQFOxEhyJPO2Sma2PsLgoYPJ169qI55ROpmC3RhSpTHYfUOGBvn4mcxWN1l FtYUUlTuwXe0V9yIWbubYa3nVP8XnoGgfoxm5+/8/CeNZ9S97iIF9syt2HS21xT11eBN MCjw86mIbwr5By/yze9qVr687ogYZx6k6gPnB90cGLw1oANtfsuLPwLNJvF7KyoW3tc3 s2PsCEbQzBb42WspPz0w3sTqsdKbbExRvYRLrUIxRKLTKVbuw73+SD3YAoEQye26Y2Xw RA== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3upjsqty38-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Dec 2023 00:45:30 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3B10jTDv011433 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 1 Dec 2023 00:45:29 GMT Received: from hu-bjorande-lv.qualcomm.com (10.49.16.6) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 30 Nov 2023 16:45:29 -0800 Date: Thu, 30 Nov 2023 16:45:27 -0800 From: Bjorn Andersson To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , "Bjorn Andersson" , Anton Bambura CC: , Rob Clark , , , Subject: Re: [PATCH] drm/msm/dpu: Add missing safe_lut_tbl in sc8180x catalog Message-ID: <20231201004527.GA1766637@hu-bjorande-lv.qualcomm.com> References: <20231130-sc8180x-dpu-safe-lut-v1-1-a8a6bbac36b8@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231130-sc8180x-dpu-safe-lut-v1-1-a8a6bbac36b8@quicinc.com> X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 0BjWzFV0nZIK4mwCBlusqT6op6eUg8gx X-Proofpoint-ORIG-GUID: 0BjWzFV0nZIK4mwCBlusqT6op6eUg8gx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-30_25,2023-11-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 bulkscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 adultscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2312010004 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 30, 2023 at 04:35:01PM -0800, Bjorn Andersson wrote: > Similar to SC8280XP, the misconfigured SAFE logic causes rather > significant delays in __arm_smmu_tlb_sync(), resulting in poor > performance for things such as USB. > > Introduce appropriate SAFE values for SC8180X to correct this. > > Fixes: f3af2d6ee9ab ("drm/msm/dpu: Add SC8180x to hw catalog") Reported-by: Anton Bambura > Signed-off-by: Bjorn Andersson > --- > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h > index e07f4c8c25b9..9ffc8804a6fc 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h > @@ -367,6 +367,7 @@ static const struct dpu_perf_cfg sc8180x_perf_data = { > .min_llcc_ib = 800000, > .min_dram_ib = 800000, > .danger_lut_tbl = {0xf, 0xffff, 0x0}, > + .safe_lut_tbl = {0xfff0, 0xf000, 0xffff}, > .qos_lut_tbl = { > {.nentry = ARRAY_SIZE(sc7180_qos_linear), > .entries = sc7180_qos_linear > > --- > base-commit: 3cd3fe06ff81cfb3a969acb12a56796cff5af23d > change-id: 20231130-sc8180x-dpu-safe-lut-ffd0df221d67 > > Best regards, > -- > Bjorn Andersson >