From: Huisong Li <lihuisong@huawei.com>
To: <xuwei5@hisilicon.com>
Cc: <linux-kernel@vger.kernel.org>, <soc@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<Jonathan.Cameron@Huawei.com>, <arnd@arndb.de>, <krzk@kernel.org>,
<sudeep.holla@arm.com>, <liuyonglong@huawei.com>,
<lihuisong@huawei.com>
Subject: [PATCH v3 2/5] soc: hisilicon: kunpeng_hccs: Add failure log for no _CRS method
Date: Fri, 1 Dec 2023 11:45:31 +0800 [thread overview]
Message-ID: <20231201034534.7276-3-lihuisong@huawei.com> (raw)
In-Reply-To: <20231201034534.7276-1-lihuisong@huawei.com>
Driver gets the PCC channel id by using the PCC GAS in _CRS.
But, currently, if the firmware has no _CRS method on platform, there
is not any failure log. So this patch adds the log for this.
Signed-off-by: Huisong Li <lihuisong@huawei.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
drivers/soc/hisilicon/kunpeng_hccs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/hisilicon/kunpeng_hccs.c b/drivers/soc/hisilicon/kunpeng_hccs.c
index dad6235dbf1a..fd3ca0eb8175 100644
--- a/drivers/soc/hisilicon/kunpeng_hccs.c
+++ b/drivers/soc/hisilicon/kunpeng_hccs.c
@@ -85,8 +85,10 @@ static int hccs_get_pcc_chan_id(struct hccs_dev *hdev)
struct hccs_register_ctx ctx = {0};
acpi_status status;
- if (!acpi_has_method(handle, METHOD_NAME__CRS))
+ if (!acpi_has_method(handle, METHOD_NAME__CRS)) {
+ dev_err(hdev->dev, "No _CRS method.\n");
return -ENODEV;
+ }
ctx.dev = hdev->dev;
status = acpi_walk_resources(handle, METHOD_NAME__CRS,
--
2.33.0
next prev parent reply other threads:[~2023-12-01 3:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 5:45 [PATCH v1 0/3] soc: hisilicon: kunpeng_hccs: Support the platform with PCC type3 and interrupt ack Huisong Li
2023-11-09 5:45 ` [PATCH v1 1/3] soc: hisilicon: kunpeng_hccs: Fix some incorrect format strings Huisong Li
2023-11-28 15:25 ` Jonathan Cameron
2023-11-09 5:45 ` [PATCH v1 2/3] soc: hisilicon: kunpeng_hccs: Add failure log for no _CRS method Huisong Li
2023-11-28 15:22 ` Jonathan Cameron
2023-11-09 5:45 ` [PATCH v1 3/3] soc: hisilicon: kunpeng_hccs: Support the platform with PCC type3 and interrupt ack Huisong Li
2023-11-28 15:44 ` Jonathan Cameron
2023-11-30 1:16 ` lihuisong (C)
2023-11-30 13:45 ` [PATCH v2 0/4] " Huisong Li
2023-11-30 13:45 ` [PATCH v2 1/4] soc: hisilicon: kunpeng_hccs: Fix some incorrect format strings Huisong Li
2023-11-30 13:45 ` [PATCH v2 2/4] soc: hisilicon: kunpeng_hccs: Add failure log for no _CRS method Huisong Li
2023-11-30 13:45 ` [PATCH v2 3/4] soc: hisilicon: kunpeng_hccs: remove an unused blank line Huisong Li
2023-11-30 14:42 ` Jonathan Cameron
2023-11-30 13:45 ` [PATCH v2 4/4] soc: hisilicon: kunpeng_hccs: Support the platform with PCC type3 and interrupt ack Huisong Li
2023-11-30 14:49 ` Jonathan Cameron
2023-12-01 2:45 ` lihuisong (C)
2023-12-01 3:45 ` [PATCH v3 0/5] " Huisong Li
2023-12-01 3:45 ` [PATCH v3 1/5] soc: hisilicon: kunpeng_hccs: Fix some incorrect format strings Huisong Li
2023-12-01 3:45 ` Huisong Li [this message]
2023-12-01 3:45 ` [PATCH v3 3/5] soc: hisilicon: kunpeng_hccs: Remove an unused blank line Huisong Li
2023-12-01 3:45 ` [PATCH v3 4/5] doc: kunpeng_hccs: Fix incorrect email domain name Huisong Li
2023-12-01 3:45 ` [PATCH v3 5/5] soc: hisilicon: kunpeng_hccs: Support the platform with PCC type3 and interrupt ack Huisong Li
2023-12-08 7:18 ` [PATCH v3 0/5] " Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231201034534.7276-3-lihuisong@huawei.com \
--to=lihuisong@huawei.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=arnd@arndb.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=soc@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®