From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 989F7C4167B for ; Fri, 1 Dec 2023 22:16:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229547AbjLAWQp (ORCPT ); Fri, 1 Dec 2023 17:16:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbjLAWQn (ORCPT ); Fri, 1 Dec 2023 17:16:43 -0500 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F242199; Fri, 1 Dec 2023 14:16:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:Mime-Version:Message-Id:Cc:To:From :Date:subject:date:message-id:reply-to; bh=RleAiTqS9FxAKMgjB0DLgFy+js7sWqfnCP+O9cXHczM=; b=ZNqSyzVgu4EjEHJuKsU/HlpIOy 4uHoNIYkAkQ+SV+kVLQkB+lH/wIY4GV/THuJgkN5U4yffWT2pGdMcYCzHlOFeyloDLIRN1m3esXN+ qHi5szrdiGILDUvtj+5ZNfzGn3AtyEiLkc+LFAI3B+pZCWXnYUPFJTaEh99lNnQemPHQ=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:50250 helo=pettiford) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1r9BoS-0006qq-HL; Fri, 01 Dec 2023 17:16:44 -0500 Date: Fri, 1 Dec 2023 17:16:44 -0500 From: Hugo Villeneuve To: Mark Brown Cc: Jan =?ISO-8859-1?Q?Kundr=E1t?= , Cosmin Tanislav , linux-serial@vger.kernel.org, Andy Shevchenko , linux-kernel@vger.kernel.org Message-Id: <20231201171644.6f7ade89d4c2f744fa3556b7@hugovil.com> In-Reply-To: References: <20231201132736.65cb0e2bff88fba85121c44a@hugovil.com> <20231201163846.a7c1d79daca7c6a2e1416a70@hugovil.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com Subject: Re: [PATCH] tty: max310x: work around regmap->regcache data corruption X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 Dec 2023 21:41:48 +0000 Mark Brown wrote: > On Fri, Dec 01, 2023 at 04:38:46PM -0500, Hugo Villeneuve wrote: > > Mark Brown wrote: > > > > If you're working on that driver it'd also be good to update the current > > > use of cache bypass for the enhanced features/interrupt identification > > > register (and anything else in there, that did seem to be the only one) > > > to use regmap ranges instead - that'd remove the need for the efr_lock > > > and be a much more sensible/idiomatic use of the regmap APIs. > > > I will also look to remove the efr_lock, altough it has more > > implications since this ship has some registers that share a common > > address, and selected by bits in other registers, and I think this > > is why there is this efr_lock. > > Right, the registers sharing a common address with the register selected > by bits in another register is what regmap ranges support - the less > creative use of this is banked blocks of registers with a selector > register which picks which page bank is in use, that's moderately common > especially for TI. Hi Mark, thanks for the info, I was not aware of that, and will look into it. Hugo Villeneuve.